Skip to content

Commit 8fd74e1

Browse files
authored
Add AI assisted PR reivew policy (#43848)
Risk Level: none Testing: n/a Docs Changes: yes Release Notes: no Platform Specific Features: no Signed-off-by: Yan Avlasov <yavlasov@google.com>
1 parent de411b9 commit 8fd74e1

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

CONTRIBUTING.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,12 @@ following guidelines for all code, APIs, and documentation:
4747

4848
## What is allowed
4949

50-
Use of generative AI to assist in writing code or tests, as long as the submitter fully understands
51-
the code being submitted.
50+
* Use of generative AI to assist in writing code or tests, as long as the submitter fully understands
51+
the code being submitted.
52+
* Use of generative AI to assist in reviewing of PRs, as long as the reviewer fully understands review
53+
comments produced by the AI review agent. AI review agent is an aid to the reviewer, not to the PR author.
5254

53-
All of the following are required:
55+
All of the following are required for AI assisted code:
5456

5557
* You understand the change you are submitting.
5658
* You respond to questions and comments from the reviewer. If you use generative AI to help in your
@@ -63,12 +65,19 @@ All of the following are required:
6365
* All generated code must be released under the same [license](LICENSE) as Envoy. You are responsible
6466
for ensuring that the tools you use to generate code do not add any additional licensing restrictions.
6567

68+
All of the following are required for AI assisted PR reviews:
69+
70+
* Remove, or resolve, hallucinated or low value PR comments from AI review agent.
71+
* Respond to the comments from the PR author in case they require clarification or disagree with AI findings.
72+
It is recommended to proactively clarify why you think AI generated comments needs to be addressed.
73+
6674
## What is not allowed
6775

6876
* PRs which the submitter does not understand or take full ownership of.
6977
* Code comments should be valuable to the codebase. Any comments which only help the AI interact with
7078
the code must be removed before the PR is submitted. Comments which explain what straightforward code
7179
does are not useful.
80+
* "Drive-by" invocation of AI review agents on PRs without the intention to follow up on produced review.
7281

7382
# Breaking change policy
7483

0 commit comments

Comments
 (0)