You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dynamic_modules: mark EnvoyHttpFilterScheduler as Sync since it's threadsafe (#41787)
Commit Message: dynamic_modules: mark EnvoyHttpFilterScheduler as Sync
since it's threadsafe
Additional Description:
I noticed the dispatcher seems to be thread-safe
https://github.com/envoyproxy/envoy/blob/d45e365e78ae391d4617d8b58236dbe67f8ebb28/source/common/event/dispatcher_impl.cc#L266
So it should be fine to mark the scheduler in dynamic modules as `Sync`.
This would allow sharing it with `Arc` instead of having to use
`new_scheduler` multiple times as I currently need to do.
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: None
Signed-off-by: Anuraag Agrawal <[email protected]>
0 commit comments