Skip to content

Commit dc10d4a

Browse files
authored
mobile: Fix tests for not setting the trusted CA when empty (#40196)
This is a follow up for #40027. Signed-off-by: Ali Beyad <[email protected]>
1 parent 72833be commit dc10d4a

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

mobile/test/cc/unit/envoy_config_test.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ TEST(TestConfig, ConfigIsApplied) {
112112
"key: \"device_os\" value { string_value: \"probably-ubuntu-on-CI\" } }",
113113
"key: \"app_version\" value { string_value: \"1.2.3\" } }",
114114
"key: \"app_id\" value { string_value: \"1234-1234-1234\" } }",
115-
"validation_context { trusted_ca {",
116115
"initial_stream_window_size { value: 6291456 }",
117116
"initial_connection_window_size { value: 15728640 }"};
118117

@@ -428,7 +427,6 @@ TEST(TestConfig, EnablePlatformCertificatesValidation) {
428427
std::unique_ptr<Bootstrap> bootstrap = engine_builder.generateBootstrap();
429428
EXPECT_THAT(bootstrap->ShortDebugString(),
430429
Not(HasSubstr("envoy_mobile.cert_validator.platform_bridge_cert_validator")));
431-
EXPECT_THAT(bootstrap->ShortDebugString(), HasSubstr("trusted_ca"));
432430

433431
engine_builder.enablePlatformCertificatesValidation(true);
434432
bootstrap = engine_builder.generateBootstrap();

mobile/test/java/io/envoyproxy/envoymobile/engine/EnvoyConfigurationTest.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,6 @@ class EnvoyConfigurationTest {
213213
assertThat(resolvedTemplate).contains("buffer_filter_1")
214214
assertThat(resolvedTemplate).contains("type.googleapis.com/envoy.extensions.filters.http.buffer.v3.Buffer")
215215

216-
// Cert Validation
217-
assertThat(resolvedTemplate).contains("trusted_ca")
218-
219216
// Validate ordering between filters and platform filters
220217
assertThat(resolvedTemplate).matches(Pattern.compile(".*name1.*name2.*buffer_filter_1.*buffer_filter_2.*", Pattern.DOTALL))
221218
// Validate that createProtoString doesn't change filter order.

0 commit comments

Comments
 (0)