Skip to content

Commit ef3f3eb

Browse files
committed
bazel: Fix package naming
Signed-off-by: Ryan Northey <ryan@synca.io>
1 parent e78436d commit ef3f3eb

File tree

15 files changed

+35
-29
lines changed

15 files changed

+35
-29
lines changed

.bcr/presubmit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ tasks:
1313
platform: ${{ unix_platform }}
1414
bazel: ${{ bazel }}
1515
build_targets:
16-
- "@envoy_examples//..."
16+
- "@envoy-examples//..."

.bcr/wasm-cc/presubmit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ tasks:
1313
platform: ${{ unix_platform }}
1414
bazel: ${{ bazel }}
1515
build_targets:
16-
- "@envoy_example_wasm_cc//..."
16+
- "@envoy-example-wasm-cc//..."

.github/workflows/docs.yml

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,26 @@ jobs:
4343
with:
4444
path: examples
4545
- run: |
46-
export UID
47-
export GID=$(id -g)
48-
49-
cat >> ../envoy/WORKSPACE << 'EOF'
50-
load("@envoy_examples//bazel:env.bzl", "envoy_examples_env")
46+
cat >> WORKSPACE << 'EOF'
47+
load("@envoy-examples//bazel:env.bzl", "envoy_examples_env")
5148
envoy_examples_env()
5249
EOF
5350
54-
cat > ../envoy/repo.bazelrc << 'EOF'
51+
cat > repo.bazelrc << 'EOF'
5552
common --config=ci
5653
common --config=rbe
5754
common --config=bes
5855
EOF
5956
57+
# temp hacks to make envoy use new names
58+
sed -i '/^[[:space:]]*external_http_archive[[:space:]]*(/,/^[[:space:]]*)[[:space:]]*$/{s/^[[:space:]]*name[[:space:]]*=[[:space:]]*"envoy_examples",[[:space:]]*$/ name = "envoy-examples",\
59+
location_name = "envoy_examples",/}' bazel/repositories.bzl
60+
git grep @envoy_example | cut -d: -f1 | sort -u | xargs sed -i s/@envoy_example/@envoy-example/g
61+
working-directory: envoy
62+
- run: |
63+
export UID
64+
export GID=$(id -g)
65+
6066
docker compose run docs
6167
working-directory: examples
6268
env:

BUILD

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ filegroup(
6868
"kafka/*.yaml",
6969
"kafka-mesh/*.yaml",
7070
],
71-
) + ["@envoy-example-wasmcc//:configs"],
71+
) + ["@envoy-example-wasm-cc//:configs"],
7272
visibility = ["//visibility:public"],
7373
)
7474

@@ -98,7 +98,7 @@ filegroup(
9898

9999
filegroup(
100100
name = "docs_rst",
101-
srcs = glob(["**/example.rst"]) + ["@envoy-example-wasmcc//:example.rst"],
101+
srcs = glob(["**/example.rst"]) + ["@envoy-example-wasm-cc//:example.rst"],
102102
)
103103

104104
pkg_files(
@@ -115,7 +115,7 @@ genrule(
115115
cmd = """
116116
TEMP=$$(mktemp -d)
117117
for location in $(locations :docs_rst); do
118-
if [[ "$$location" == *"/envoy-example"* ]]; then
118+
if [[ "$$location" == *"/envoy-example-"* ]]; then
119119
example="$$(echo "$$location" | cut -d- -f3- | cut -d/ -f1)"
120120
else
121121
example=$$(echo $$location | sed -e 's#^external/[^/]*/##' | cut -d/ -f1)
@@ -165,7 +165,7 @@ pkg_tar(
165165
package_dir = "start/sandboxes",
166166
deps = [
167167
":examples_docs",
168-
"@envoy-example-wasmcc//:includes",
168+
"@envoy-example-wasm-cc//:includes",
169169
],
170170
visibility = ["//visibility:public"],
171171
)

MODULE.bazel

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
module(
2-
name = "envoy_examples",
2+
name = "envoy-examples",
33
version = "0.1.6-dev",
44
)
55

6+
bazel_dep(name = "envoy-example-wasm-cc", version = "0.1.6-dev")
67
bazel_dep(name = "rules_go", version = "0.59.0", repo_name = "io_bazel_rules_go")
78
bazel_dep(name = "rules_pkg", version = "1.1.0")
89
bazel_dep(name = "rules_python", version = "1.7.0")
910
bazel_dep(name = "rules_shell", version = "0.6.1")
10-
bazel_dep(name = "envoy_example_wasm_cc", version = "0.1.6-dev")
11+
1112
local_path_override(
12-
module_name = "envoy_example_wasm_cc",
13+
module_name = "envoy-example-wasm-cc",
1314
path = "wasm-cc",
1415
)

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
workspace(name = "envoy_examples")
1+
workspace(name = "envoy-examples")
22

33
load("//bazel:env.bzl", "envoy_examples_env")
44
envoy_examples_env()

bazel/archives.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
2-
load("@envoy-example-wasmcc//bazel:archives.bzl", "load_envoy_example_wasmcc_archives")
2+
load("@envoy-example-wasm-cc//bazel:archives.bzl", "load_envoy_example_wasmcc_archives")
33
load("//bazel:versions.bzl", "VERSIONS")
44

55
def load_github_archives():

bazel/deps.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
load("@envoy-example-wasmcc//bazel:deps.bzl", "resolve_envoy_example_wasmcc_dependencies")
1+
load("@envoy-example-wasm-cc//bazel:deps.bzl", "resolve_envoy_example_wasmcc_dependencies")
22
load("@io_bazel_rules_go//go:deps.bzl", "go_rules_dependencies")
33
load("@rules_python//python:repositories.bzl", "py_repositories")
44

bazel/env.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ _envoy_examples_env = repository_rule(
1212
)
1313

1414
def envoy_examples_env():
15-
_envoy_examples_env(name = "envoy_examples_env")
15+
_envoy_examples_env(name = "envoy-examples-env")
1616
load_envoy_nested_examples()

bazel/nested.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ def _example_repo_impl(ctx):
1616
example_repository = repository_rule(
1717
implementation = _example_repo_impl,
1818
attrs = {
19-
"examples_root": attr.label(default = "@envoy_examples//:BUILD"),
19+
"examples_root": attr.label(default = "@envoy-examples//:BUILD"),
2020
"path": attr.string(mandatory=True),
2121
},
2222
)
2323

2424
def load_envoy_nested_examples():
2525
example_repository(
26-
name = "envoy-example-wasmcc",
26+
name = "envoy-example-wasm-cc",
2727
path = "wasm-cc",
2828
)

0 commit comments

Comments
 (0)