chore: rename runner methods that no longer subscribe (#7164)

Signed-off-by: Rudrakh Panigrahi <[email protected]>

Author: rudrakhp

internal/globalratelimit/runner/runner.go

@@ -102,7 +102,7 @@ func (r *Runner) Start(ctx context.Context) (err error) {
 	// Do not call .Subscribe() inside Goroutine since it is supposed to be called from the same
 	// Goroutine where Close() is called.
 	c := r.XdsIR.Subscribe(ctx)
-	go r.subscribeAndTranslate(ctx, c)
+	go r.translateFromSubscription(ctx, c)
 
 	r.Logger.Info("started")
 	return
@@ -136,7 +136,7 @@ func buildXDSResourceFromCache(rateLimitConfigsCache map[string][]cachetype.Reso
 	return xdsResourcesToUpdate
 }
 
-func (r *Runner) subscribeAndTranslate(ctx context.Context, c <-chan watchable.Snapshot[string, *ir.Xds]) {
+func (r *Runner) translateFromSubscription(ctx context.Context, c <-chan watchable.Snapshot[string, *ir.Xds]) {
 	// rateLimitConfigsCache is a cache of the rate limit config, which is keyed by the xdsIR key.
 	rateLimitConfigsCache := map[string][]cachetype.Resource{}
 

internal/globalratelimit/runner/runner_test.go

@@ -220,7 +220,7 @@ func Test_subscribeAndTranslate(t *testing.T) {
 			})
 
 			c := xdsIR.Subscribe(ctx)
-			go r.subscribeAndTranslate(ctx, c)
+			go r.translateFromSubscription(ctx, c)
 
 			for _, xds := range tt.xdsIRs {
 				if xds.Delete {

internal/infrastructure/runner/runner.go

@@ -61,7 +61,7 @@ func (r *Runner) Start(ctx context.Context) (err error) {
 	subscribeInitInfraAndCloseInfraIRMessage := func() {
 		// Subscribe and Close in same goroutine to avoid race condition.
 		sub := r.InfraIR.Subscribe(ctx)
-		go r.subscribeToProxyInfraIR(ctx, sub)
+		go r.updateProxyInfraFromSubscription(ctx, sub)
 
 		// Enable global ratelimit if it has been configured.
 		if r.EnvoyGateway.RateLimit != nil {
@@ -102,7 +102,7 @@ func (r *Runner) Start(ctx context.Context) (err error) {
 	return
 }
 
-func (r *Runner) subscribeToProxyInfraIR(ctx context.Context, sub <-chan watchable.Snapshot[string, *ir.Infra]) {
+func (r *Runner) updateProxyInfraFromSubscription(ctx context.Context, sub <-chan watchable.Snapshot[string, *ir.Infra]) {
 	// Subscribe to resources
 	message.HandleSubscription(message.Metadata{Runner: r.Name(), Message: message.InfraIRMessageName}, sub,
 		func(update message.Update[string, *ir.Infra], errChan chan error) {

internal/provider/kubernetes/controller.go

@@ -203,7 +203,7 @@ func newGatewayAPIController(ctx context.Context, mgr manager.Manager, cfg *conf
 		// Subscribe to resource updates
 		r.subscribeToResources(ctx)
 		// Update status
-		go r.subscribeAndUpdateStatus(ctx, cfg.EnvoyGateway.ExtensionManager != nil)
+		go r.updateStatusFromSubscriptions(ctx, cfg.EnvoyGateway.ExtensionManager != nil)
 		r.log.Info("started")
 		// Close resources if the context is done.
 		<-ctx.Done()

internal/provider/kubernetes/controller_offline.go

@@ -100,7 +100,7 @@ func NewOfflineGatewayAPIController(
 	r.subscribeToResources(ctx)
 
 	if su != nil {
-		r.subscribeAndUpdateStatus(ctx, cfg.EnvoyGateway.ExtensionManager != nil)
+		r.updateStatusFromSubscriptions(ctx, cfg.EnvoyGateway.ExtensionManager != nil)
 	}
 
 	return &OfflineGatewayAPIReconciler{

internal/provider/kubernetes/status.go

@@ -23,9 +23,8 @@ import (
 	"github.com/envoyproxy/gateway/internal/utils"
 )
 
-// subscribeAndUpdateStatus subscribes to gateway API object status updates and
-// writes it into the Kubernetes API Server.
-func (r *gatewayAPIReconciler) subscribeAndUpdateStatus(ctx context.Context, extensionManagerEnabled bool) {
+// updateStatusFromSubscriptions writes gateway API object status updates to the Kubernetes API server.
+func (r *gatewayAPIReconciler) updateStatusFromSubscriptions(ctx context.Context, extensionManagerEnabled bool) {
 	// GatewayClass object status updater
 	go func() {
 		message.HandleSubscription(

internal/xds/runner/runner.go

@@ -182,7 +182,7 @@ func (r *Runner) Start(ctx context.Context) (err error) {
 	// Do not call .Subscribe() inside Goroutine since it is supposed to be called from the same
 	// Goroutine where Close() is called.
 	sub := r.XdsIR.Subscribe(ctx)
-	go r.subscribeAndTranslate(sub)
+	go r.translateFromSubscription(sub)
 	r.Logger.Info("started")
 	return
 }
@@ -223,7 +223,7 @@ func registerServer(srv serverv3.Server, g *grpc.Server) {
 	runtimev3.RegisterRuntimeDiscoveryServiceServer(g, srv)
 }
 
-func (r *Runner) subscribeAndTranslate(sub <-chan watchable.Snapshot[string, *ir.Xds]) {
+func (r *Runner) translateFromSubscription(sub <-chan watchable.Snapshot[string, *ir.Xds]) {
 	// Subscribe to resources
 	message.HandleSubscription(message.Metadata{Runner: r.Name(), Message: message.XDSIRMessageName}, sub,
 		func(update message.Update[string, *ir.Xds], errChan chan error) {