Skip to content

Commit 5259769

Browse files
committed
typo tweak
Signed-off-by: Elizabeth Byerly <ebyerly@google.com>
1 parent 86227ae commit 5259769

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/check-envoy-commits.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: "Get Nighthawk's current Envoy commit"
2525
id: get_current_envoy_commit
2626
run: |
27-
CURRENT_ENVOY_COMMIT=$(cat nighthawk/bazel/repositories.bzl | sed -nE 's/^ENVOY_COMMIT = "(.*)"$/\1/p')
27+
CURRENT_ENVOY_COMMIT=$(cat ./nighthawk/bazel/repositories.bzl | sed -nE 's/^ENVOY_COMMIT = "(.*)"$/\1/p')
2828
echo "CURRENT_ENVOY_COMMIT=${CURRENT_ENVOY_COMMIT}"
2929
echo "CURRENT_ENVOY_COMMIT=${CURRENT_ENVOY_COMMIT}" >> $GITHUB_ENV
3030
@@ -104,13 +104,13 @@ jobs:
104104
echo " ${ENVOY_MODIFIED_COMMITS[@]}"
105105
for commit in ${ENVOY_MODIFIED_COMMITS[@]}; do
106106
echo ${commit};
107-
SHARED_MODIFIED=$(git -C ~/github/envoy show ${commit} --name-only --pretty="" -- ${SHARED_FILES[@]})
107+
SHARED_MODIFIED="$(git -C ~/github/envoy show ${commit} --name-only --pretty="" -- ${SHARED_FILES[@]})"
108108
github.rest.issues.create({
109109
owner: context.repo.owner,
110110
repo: context.repo.repo,
111-
title: `Non-trivial Envoy commit increment: \`${commit}\``,
111+
title: "Non-trivial Envoy commit increment: ${commit}",
112112
labels: ["bug", "automation", "check-envoy-commits", "manual-action-required"],
113-
body: `An Envoy commit between the current Nighthawk dependency and latest has modified a shared file.\n\n**Envoy Commit:** \`${commit}\`\n\n\n\n**Shared files modified:** \`${SHARED_MODIFIED[@]}\`\n\nA human is required to review and merge the changes from this file into Nighthawk's copy.\n\nThis workflow will be blocked until this file is updated and the corresponding Nighthawk dependency on Envoy is updated past this commit.`
113+
body: "An Envoy commit between the current Nighthawk dependency and latest has modified a shared file.\n\n**Envoy Commit:** ${commit}\n\n\n\n**Shared files modified:** ${SHARED_MODIFIED}\n\nA human is required to review and merge the changes from this file into Nighthawk's copy.\n\nThis workflow will be blocked until this file is updated and the corresponding Nighthawk dependency on Envoy is updated past this commit."
114114
});
115115
done
116116
fi

0 commit comments

Comments
 (0)