Skip to content

Commit a1dba8f

Browse files
committed
comment out unsupported GH interaction
Signed-off-by: Elizabeth Byerly <ebyerly@google.com>
1 parent a0349ff commit a1dba8f

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

.github/workflows/check-envoy-commits.yml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,10 @@ jobs:
4444
echo "decision=proceed" >> $GITHUB_OUTPUT
4545
4646
# Get all open issues created by this automation.
47-
OPEN_ISSUES_JSON=$(gh issue list --repo ${{ github.repository }} --label "github_actions" --state open --json number,title)
47+
# DO NOT SUBMIT - rely on a workflow-unique "check-envoy-commits" label
48+
OPEN_ISSUES_JSON=$(
49+
gh issue list --repo ${{ github.repository }} \
50+
--label "github_actions" --state open --json number,title)
4851
4952
if [[ -z "$OPEN_ISSUES_JSON" || "$OPEN_ISSUES_JSON" == "[]" ]]; then
5053
echo "No known open issues found. Proceeding with analysis."
@@ -115,6 +118,7 @@ jobs:
115118
)
116119
# DO NOT SUBMIT - we must enable Github Actions to open, comment, and close issues
117120
echo "$(printf "%s\n" "${BODY_PARTS[@]}")"
121+
# DO NOT SUBMIT - add a workflow-unique "check-envoy-commits" label
118122
# gh issue create --repo ${{ github.repository }} \
119123
# --title "Non-trivial Envoy commit increment: ${commit} modifies shared files" \
120124
# --body "$(printf "%s\n" "${BODY_PARTS[@]}")" \
@@ -131,7 +135,7 @@ jobs:
131135
id: build_with_latest_commit
132136
run: |
133137
chmod +x ./nighthawk/tools/bisect-envoy.sh
134-
./nighthawk/tools/bisect-envoy.sh ${{ env.LATEST_ENVOY_COMMIT }} "$(pwd)/nighthawk" > build_with_latest_commit.log 2>&1
138+
./nighthawk/tools/bisect-envoy.sh ${{ env.LATEST_ENVOY_COMMIT }} ./nighthawk > build_with_latest_commit.log 2>&1
135139
continue-on-error: true
136140

137141
- name: "Bisect to find the first Envoy commit that causes the break"
@@ -143,7 +147,7 @@ jobs:
143147
git -C ./envoy bisect start ${{ env.LATEST_ENVOY_COMMIT }} ${{ env.CURRENT_ENVOY_COMMIT }}
144148
145149
BISECT_LOG_FILE=$(mktemp)
146-
git -C ./envoy bisect run ./nighthawk/tools/bisect-envoy.sh "$(pwd)/nighthawk" | tee ${BISECT_LOG_FILE}
150+
git -C ./envoy bisect run ./nighthawk/tools/bisect-envoy.sh ./nighthawk | tee ${BISECT_LOG_FILE}
147151
148152
ENVOY_BREAK_COMMIT=$(grep -oP '^\w+(?=\s+is the first bad commit)' ${BISECT_LOG_FILE} || echo "NOT_FOUND")
149153
echo "ENVOY_BREAK_COMMIT=${ENVOY_BREAK_COMMIT}" >> $GITHUB_ENV
@@ -157,23 +161,19 @@ jobs:
157161
id: create_issue
158162
env:
159163
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
160-
uses: actions/github-script@v6
161-
with:
162-
script: |
163-
const { ENVOY_BREAK_COMMIT } = process.env;
164-
const logBody = `${{ steps.bisect.outputs.BISECT_LOG }}`;
165-
BODY_PARTS=(
166-
"Automated bisection identified Envoy commit ${ENVOY_BREAK_COMMIT} as the first commit to break the Nighthawk build."
167-
"**Bisection Log:**"
168-
"${logBody}"
169-
)
164+
ENVOY_BREAK_COMMIT: ${{ env.ENVOY_BREAK_COMMIT }}
165+
BISECT_LOG: ${{ steps.bisect.outputs.BISECT_LOG }}
166+
run: |
167+
BODY_PARTS=(
168+
"Automated bisection identified Envoy commit ${ENVOY_BREAK_COMMIT} as the first commit to break the Nighthawk build."
169+
"**Bisection Log:**"
170+
"${BISECT_LOG}"
171+
)
170172
171-
# DO NOT SUBMIT - we must enable Github Actions to open, comment, and close issues
172-
echo "$(printf "%s\n" "${BODY_PARTS[@]}")"
173-
# github.rest.issues.create({
174-
# owner: context.repo.owner,
175-
# repo: context.repo.repo,
176-
# title: "Non-trivial Envoy commit increment: ${ENVOY_BREAK_COMMIT} fails tests",
177-
# labels: ["dependencies", "github_actions"],
178-
# body: "$(printf "%s\n" "${BODY_PARTS[@]}")"
179-
# });
173+
# DO NOT SUBMIT - we must enable Github Actions to open, comment, and close issues
174+
echo "$(printf "%s\n" "${BODY_PARTS[@]}")"
175+
# DO NOT SUBMIT - add a workflow-unique "check-envoy-commits" label
176+
# gh issue create --repo "${{ github.repository }}" \
177+
# --title "Non-trivial Envoy commit increment: ${ENVOY_BREAK_COMMIT} fails tests" \
178+
# --body "$(printf "%s\n" "${BODY_PARTS[@]}")" \
179+
# --label "dependencies,github_actions"

0 commit comments

Comments
 (0)