Skip to content

[BUG] Serious Issues with Rate Calculations #248

@emfisk

Description

@emfisk

In GridWalkPhotonPackage, for example:

...
case iHI:
flux_floor *= RateData.k24;
break;
case iHeI:
flux_floor *= RateData.k25;
break;
case iHeII:
flux_floor *= RateData.k26;
break;
...
Here k25 represents the HeI rate, and k26 represents the HeII rate.

In solve_rate_cool.F:

...
enddo
if (iradshield == 1) then
do i = is+1, ie+1
if (itmask(i)) then
k24shield(i) = k24shield(i)*exp(-HI(i,j,k)avgsighpdom)
k25shield(i) = k25shield(i)*exp(-HeII(i,j,k)avgsighe2pdom)
k26shield(i) = k26shield(i)*exp(-HeI(i,j,k)avgsighepdom)
endif
enddo
endif
...
However, in this file, k25 is the HeII rate and k26 is the HeI rate. This is not consistent. It seems like different parts of the code are treating the same variable as different things.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions