Rename toWarnDev -> toErrorDev, toLowPriorityWarnDev -> toWarnDev (#17605)

* Rename toWarnDev -> toErrorDev in tests

* Rename toWarnDev matcher implementation to toErrorDev

* Rename toLowPriorityWarnDev -> toWarnDev in tests and implementation

Author: gaearon

src/__tests__/ReactShallowRenderer-test.js

@@ -1195,7 +1195,7 @@ describe('ReactShallowRenderer', () => {
     }
 
     const shallowRenderer = createRenderer();
-    expect(() => shallowRenderer.render(<SimpleComponent />)).toWarnDev(
+    expect(() => shallowRenderer.render(<SimpleComponent />)).toErrorDev(
       'Warning: Failed context type: The context `name` is marked as ' +
         'required in `SimpleComponent`, but its value is `undefined`.\n' +
         '    in SimpleComponent (at **)',
@@ -1216,7 +1216,7 @@ describe('ReactShallowRenderer', () => {
     const shallowRenderer = createRenderer();
     expect(() =>
       shallowRenderer.render(React.createElement(SimpleComponent, {name: 123})),
-    ).toWarnDev(
+    ).toErrorDev(
       'Warning: Failed prop type: Invalid prop `name` of type `number` ' +
         'supplied to `SimpleComponent`, expected `string`.\n' +
         '    in SimpleComponent',
@@ -1344,7 +1344,7 @@ describe('ReactShallowRenderer', () => {
 
     const renderAndVerifyWarningAndError = (Component, typeString) => {
       expect(() => {
-        expect(() => shallowRenderer.render(<Component />)).toWarnDev(
+        expect(() => shallowRenderer.render(<Component />)).toErrorDev(
           'React.createElement: type is invalid -- expected a string ' +
             '(for built-in components) or a class/function (for composite components) ' +
             `but got: ${typeString}.`,
@@ -1555,7 +1555,7 @@ describe('ReactShallowRenderer', () => {
       expect(() => {
         const SomeComponent = React.forwardRef(SomeMemoComponent);
         shallowRenderer.render(<SomeComponent ref={testRef} />);
-      }).toWarnDev(
+      }).toErrorDev(
         'Warning: forwardRef requires a render function but received ' +
           'a `memo` component. Instead of forwardRef(memo(...)), use ' +
           'memo(forwardRef(...))',

src/__tests__/ReactShallowRendererMemo-test.js

@@ -1242,7 +1242,7 @@ describe('ReactShallowRendererMemo', () => {
     );
 
     const shallowRenderer = createRenderer();
-    expect(() => shallowRenderer.render(<SimpleComponent />)).toWarnDev(
+    expect(() => shallowRenderer.render(<SimpleComponent />)).toErrorDev(
       'Warning: Failed context type: The context `name` is marked as ' +
         'required in `SimpleComponent`, but its value is `undefined`.\n' +
         '    in SimpleComponent (at **)',
@@ -1265,7 +1265,7 @@ describe('ReactShallowRendererMemo', () => {
     const shallowRenderer = createRenderer();
     expect(() =>
       shallowRenderer.render(React.createElement(SimpleComponent, {name: 123})),
-    ).toWarnDev(
+    ).toErrorDev(
       'Warning: Failed prop type: Invalid prop `name` of type `number` ' +
         'supplied to `SimpleComponent`, expected `string`.\n' +
         '    in SimpleComponent',
@@ -1401,7 +1401,7 @@ describe('ReactShallowRendererMemo', () => {
 
     const renderAndVerifyWarningAndError = (Component, typeString) => {
       expect(() => {
-        expect(() => shallowRenderer.render(<Component />)).toWarnDev(
+        expect(() => shallowRenderer.render(<Component />)).toErrorDev(
           'React.createElement: type is invalid -- expected a string ' +
             '(for built-in components) or a class/function (for composite components) ' +
             `but got: ${typeString}.`,

src/__tests__/ReactTestRenderer-test.internal.js

@@ -281,7 +281,7 @@ describe('ReactTestRenderer', () => {
       }
     }
     ReactTestRenderer.create(<Baz />);
-    expect(() => ReactTestRenderer.create(<Foo />)).toWarnDev(
+    expect(() => ReactTestRenderer.create(<Foo />)).toErrorDev(
       'Warning: Function components cannot be given refs. Attempts ' +
         'to access this ref will fail. ' +
         'Did you mean to use React.forwardRef()?\n\n' +

src/__tests__/ReactTestRenderer-test.js

@@ -34,7 +34,7 @@ describe('ReactTestRenderer', () => {
       expect(() => {
         ReactTestRenderer.create(ReactDOM.createPortal('foo', container));
       }).toThrow();
-    }).toWarnDev('An invalid container has been provided.', {
+    }).toErrorDev('An invalid container has been provided.', {
       withoutStack: true,
     });
   });

src/__tests__/ReactTestRendererAct-test.js

@@ -50,7 +50,7 @@ describe('ReactTestRenderer.act()', () => {
 
     expect(() => {
       setCtr(1);
-    }).toWarnDev([
+    }).toErrorDev([
       'An update to App inside a test was not wrapped in act(...)',
     ]);
   });