fix: return fresh deployment on rolling update (#168)

Author: Pasichniuk

src/main/java/com/epam/aidial/deployment/manager/service/deployment/AbstractDeploymentManager.java

@@ -176,12 +176,12 @@ public void afterCommit() {
 
     @Override
     @Transactional(isolation = Isolation.REPEATABLE_READ)
-    public void rollingUpdate(String id) {
+    public Deployment rollingUpdate(String id) {
         var deployment = getDeployment(id);
 
         if (deployment.getStatus() != DeploymentStatus.RUNNING) {
             log.info("Deployment '{}' is not running; skipping rolling update", id);
-            return;
+            return deployment;
         }
 
         try {
@@ -201,6 +201,9 @@ public void afterCommit() {
                 }
             });
 
+            deployment.setStatus(DeploymentStatus.PENDING);
+            return deployment;
+
         } catch (Exception e) {
             var errorMessage = "Rolling update failed for deployment '%s'".formatted(id);
             log.warn(errorMessage, e);

src/main/java/com/epam/aidial/deployment/manager/service/deployment/DeploymentManager.java

@@ -27,7 +27,7 @@ public interface DeploymentManager<S> {
 
     Deployment undeploy(String id);
 
-    void rollingUpdate(String id);
+    Deployment rollingUpdate(String id);
 
     void updateCiliumNetworkPolicy(String id);
 

src/main/java/com/epam/aidial/deployment/manager/service/deployment/DeploymentService.java

@@ -181,7 +181,7 @@ public Deployment updateDeployment(String id, CreateDeployment request) {
 
         boolean isApplicableForRollingUpdate = isApplicableForRollingUpdate(existingDeploymentWithResolvedSecrets, updatedDeployment, envsAreChanged);
         if (updatedDeployment.getStatus() == DeploymentStatus.RUNNING && isApplicableForRollingUpdate) {
-            deploymentManager.rollingUpdate(id);
+            updatedDeployment = deploymentManager.rollingUpdate(id);
         } else if (updatedDeployment.getStatus() == DeploymentStatus.CRASHED) {
             updatedDeployment = deploymentManager.undeploy(id);
         }

src/test/java/com/epam/aidial/deployment/manager/functional/tests/DeploymentFunctionalTest.java

@@ -416,6 +416,7 @@ public void shouldSuccessfullyUpdateDeploymentIfRunningAndImageChanged() {
         Assertions.assertEquals("updated-deployment", updatedDeployment.getDisplayName());
         Assertions.assertEquals(savedDeployment.getId(), updatedDeployment.getId());
         Assertions.assertEquals(newImageDefinitionId, updatedDeployment.getImageDefinitionId());
+        Assertions.assertEquals(DeploymentStatus.PENDING, updatedDeployment.getStatus());
 
         verify(resource, times(1)).update();
     }