Skip to content

Commit 8a78f86

Browse files
feat: use model name as deployment name (#62)
1 parent ccebbc8 commit 8a78f86

File tree

6 files changed

+26
-1
lines changed

6 files changed

+26
-1
lines changed

src/main/java/com/epam/aidial/deployment/manager/service/manifest/InferenceManifestGenerator.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
@LogExecution
2525
public class InferenceManifestGenerator extends DeployableManifestGenerator {
2626

27+
private static final String MODEL_NAME_ARGUMENT_NAME = "--model_name";
28+
2729
public InferenceManifestGenerator(AppProperties appconfig) {
2830
super(appconfig);
2931
}
@@ -72,6 +74,11 @@ public InferenceService serviceConfig(
7274
modelChain.get(InferenceMappers.MODEL_ARGS_FIELD).data().addAll(args);
7375
}
7476

77+
// Explicitly set model name to ensure the model uses the intended name.
78+
// If omitted, the inference service will default to the Kubernetes service name,
79+
// which may differ from the actual model name due to naming transformations.
80+
modelChain.get(InferenceMappers.MODEL_ARGS_FIELD).data().addAll(List.of(MODEL_NAME_ARGUMENT_NAME, name));
81+
7582
var envListMapper = modelChain
7683
.getList(InferenceMappers.MODEL_ENV_FIELD, InferenceMappers.ENV_VAR_NAME);
7784
applySimpleEnvs(envListMapper, envs, Env::setValue);

src/test/resources/manifest/inference_service_with_args.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
"--arg1",
1212
"value1",
1313
"--arg2",
14-
"value2"
14+
"value2",
15+
"--model_name",
16+
"args-inference-app"
1517
],
1618
"env": [],
1719
"modelFormat": {

src/test/resources/manifest/inference_service_with_envs.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
"spec": {
88
"predictor": {
99
"model": {
10+
"args": [
11+
"--model_name",
12+
"basic-inference-app"
13+
],
1014
"env": [
1115
{
1216
"name": "SIMPLE_VAR",

src/test/resources/manifest/inference_service_with_port.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
"spec": {
88
"predictor": {
99
"model": {
10+
"args": [
11+
"--model_name",
12+
"custom-port-inference-app"
13+
],
1014
"env": [],
1115
"modelFormat": {
1216
"name": "huggingface"

src/test/resources/manifest/inference_service_with_resources.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
"spec": {
88
"predictor": {
99
"model": {
10+
"args": [
11+
"--model_name",
12+
"resource-inference-app"
13+
],
1014
"env": [],
1115
"modelFormat": {
1216
"name": "huggingface"

src/test/resources/manifest/inference_service_with_scaling.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
"maxReplicas": 5,
1010
"minReplicas": 1,
1111
"model": {
12+
"args": [
13+
"--model_name",
14+
"scaling-inference-app"
15+
],
1216
"env": [],
1317
"modelFormat": {
1418
"name": "huggingface"

0 commit comments

Comments
 (0)