feat: support scaling config for knative deployment types by oleksii-donets · Pull Request #179 · epam/ai-dial-admin-deployment-manager-backend

oleksii-donets · 2026-02-27T13:47:20Z

Applicable issues

fixes [Deployments] Support scaling configuration for MCP, Adapters, and Interceptors #161

Description of changes

Support scaling configuration for knative deployment types (MCP, Adapter, Interceptor)
Move scaling property to base deployment class and base deployment DB table, so all deployment types share the same scaling contract
Migrate existing inference scaling data from inference_deployment child table to the base deployment table (V1.47)
Remove deprecated initialScale/minScale/maxScale fields from entities, models, DTOs, validators, mappers, services, and all test resources — replaced entirely by the Scaling object
Drop initial_scale, min_scale, max_scale columns from the deployment table (V1.47 migration)
Remove ValidScaleConfiguration annotation and ScaleConfigurationValidator (no longer needed)
Remove redundant Lombok annotations from empty Adapter/Interceptor subclasses
Add scaling coverage to config export/import functional test
Integrate ProgressDeadlineCalculator with the new scaling approach in manifest generators

Checklist

Title of the pull request follows Conventional Commits specification

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Move scaling from base deployment/request/response classes into concrete child models and DTOs so MCP, Adapter, Interceptor, and Inference carry explicit scaling contracts. Made-with: Cursor

ai-dial-actions · 2026-02-27T13:48:14Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

ai-dial-actions · 2026-02-27T18:30:50Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

ai-dial-actions · 2026-03-02T07:46:41Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

Pasichniuk · 2026-03-02T13:08:31Z

Can you explain please what are the benefits of not keeping scaling in base deployment classes?

...ain/java/com/epam/aidial/deployment/manager/service/manifest/InferenceManifestGenerator.java

src/main/java/com/epam/aidial/deployment/manager/service/manifest/KnativeManifestGenerator.java

src/main/resources/db/migration/H2/V1.47__AddScalingToKnativeDeploymentTables.sql

src/main/java/com/epam/aidial/deployment/manager/web/validation/ScalingValidator.java

...ain/java/com/epam/aidial/deployment/manager/service/deployment/KnativeDeploymentManager.java

Made-with: Cursor

oleksii-donets · 2026-03-02T15:20:02Z

Can you explain please what are the benefits of not keeping scaling in base deployment classes?

It does not apply to NIM deployments yet

Replace nested null-check + type-check with early return pattern in InferenceManifestGenerator and KnativeManifestGenerator. Made-with: Cursor

ai-dial-actions · 2026-03-02T15:44:09Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

ai-dial-actions · 2026-03-02T16:15:19Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

ai-dial-actions · 2026-03-03T09:05:40Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

ai-dial-actions · 2026-03-04T10:07:06Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

src/main/java/com/epam/aidial/deployment/manager/service/deployment/DeploymentService.java

ai-dial-actions · 2026-03-05T14:47:36Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

Move the scaling property from child-specific deployment entities, models, DTOs, and DB tables into the base deployment class hierarchy. This eliminates instanceof checks and switch statements for accessing scaling, as requested in PR #179 review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ration Instead of adding scaling to child tables and then moving it, modify V1.47 to add scaling directly to the base deployment table and migrate existing inference_deployment scaling data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ai-dial-actions · 2026-03-05T16:09:55Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

src/main/resources/db/migration/H2/V1.47__AddScalingToDeploymentTable.sql

...n/java/com/epam/aidial/deployment/manager/dao/entity/deployment/AdapterDeploymentEntity.java

src/test/resources/manifest/knative_service_with_scaling.json

@Getter

…d scaling to export/import test - Remove redundant @Getter, @Setter, @EqualsAndHashCode from Adapter and Interceptor classes that have no fields (inherited from parent @DaTa) - Add Scaling configuration to config export/import functional test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ai-dial-actions · 2026-03-06T09:23:39Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

Resolve merge conflicts in InferenceManifestGenerator and KnativeManifestGenerator: integrate ProgressDeadlineCalculator with the new Scaling-based approach. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ai-dial-actions · 2026-03-06T09:42:07Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

ai-dial-actions · 2026-03-06T09:45:23Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

src/main/java/com/epam/aidial/deployment/manager/model/deployment/CreateDeployment.java

These fields were never used in production and are fully replaced by the Scaling object. Removed from entities, models, DTOs, validators, mappers, services, and all test resources. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ai-dial-actions · 2026-03-06T10:39:11Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

ai-dial-actions · 2026-03-06T10:41:04Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

src/main/resources/db/migration/H2/V1.47__AddScalingToDeploymentTable.sql

Add DROP COLUMN statements to V1.47 migration for H2, PostgreSQL, and MS SQL Server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ai-dial-actions · 2026-03-06T10:58:18Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

settings.gradle

Package	Version	License	Issue Type
com.gradle:common-custom-user-data-gradle-plugin	2.1	Null	Unknown License
com.gradle:develocity-gradle-plugin	4.2	Null	Unknown License

OpenSSF Scorecard

Package	Version	Score	Details
maven/com.gradle:common-custom-user-data-gradle-plugin	2.1	Unknown	Unknown
maven/com.gradle:develocity-gradle-plugin	4.2	Unknown	Unknown

Scanned Files

settings.gradle

Pasichniuk · 2026-03-06T11:05:17Z

Please consider marking PR as a breaking change due to API changes & update description

feat: support scaling config for knative deployment types

7867b3b

Move scaling from base deployment/request/response classes into concrete child models and DTOs so MCP, Adapter, Interceptor, and Inference carry explicit scaling contracts. Made-with: Cursor

oleksii-donets requested a review from siarhei-fedziukovich as a code owner February 27, 2026 13:47

feat: improvements

11e8e09

oleksii-donets requested a review from Pasichniuk March 2, 2026 07:45

Merge branch 'development' into feature/161-scaling-knative-types

257d514

Pasichniuk reviewed Mar 2, 2026

View reviewed changes

...ain/java/com/epam/aidial/deployment/manager/service/manifest/InferenceManifestGenerator.java Outdated Show resolved Hide resolved

Pasichniuk reviewed Mar 2, 2026

View reviewed changes

src/main/java/com/epam/aidial/deployment/manager/service/manifest/KnativeManifestGenerator.java Outdated Show resolved Hide resolved

Pasichniuk reviewed Mar 2, 2026

View reviewed changes

src/main/java/com/epam/aidial/deployment/manager/service/manifest/KnativeManifestGenerator.java Outdated Show resolved Hide resolved

Pasichniuk reviewed Mar 2, 2026

View reviewed changes

src/main/java/com/epam/aidial/deployment/manager/service/manifest/KnativeManifestGenerator.java Outdated Show resolved Hide resolved

Pasichniuk reviewed Mar 2, 2026

View reviewed changes

src/main/resources/db/migration/H2/V1.47__AddScalingToKnativeDeploymentTables.sql Outdated Show resolved Hide resolved

Pasichniuk reviewed Mar 2, 2026

View reviewed changes

src/main/java/com/epam/aidial/deployment/manager/web/validation/ScalingValidator.java Show resolved Hide resolved

Pasichniuk reviewed Mar 2, 2026

View reviewed changes

...ain/java/com/epam/aidial/deployment/manager/service/deployment/KnativeDeploymentManager.java Outdated Show resolved Hide resolved

Merge branch 'development' into feature/161-scaling-knative-types

0c139a3

Made-with: Cursor

oleksii-donets added 2 commits March 2, 2026 17:26

refactor: flatten nested if-cases in scaling strategy handling

39854eb

Replace nested null-check + type-check with early return pattern in InferenceManifestGenerator and KnativeManifestGenerator. Made-with: Cursor

chore: fix PR comments

e38597d

chore: fix tests

b2eb3bf

Merge branch 'development' into feature/161-scaling-knative-types

76fd8b4

Merge branch 'development' into feature/161-scaling-knative-types

8d3a4aa

Pasichniuk reviewed Mar 4, 2026

View reviewed changes

src/main/java/com/epam/aidial/deployment/manager/service/deployment/DeploymentService.java Outdated Show resolved Hide resolved

Merge branch 'development' into feature/161-scaling-knative-types

24dc564

oleksii-donets and others added 2 commits March 5, 2026 17:43

Pasichniuk reviewed Mar 6, 2026

View reviewed changes

src/main/resources/db/migration/H2/V1.47__AddScalingToDeploymentTable.sql Show resolved Hide resolved

Pasichniuk reviewed Mar 6, 2026

View reviewed changes

...n/java/com/epam/aidial/deployment/manager/dao/entity/deployment/AdapterDeploymentEntity.java Outdated Show resolved Hide resolved

Pasichniuk reviewed Mar 6, 2026

View reviewed changes

src/test/resources/manifest/knative_service_with_scaling.json Show resolved Hide resolved

Merge development into feature/161-scaling-knative-types

bd5f638

Resolve merge conflicts in InferenceManifestGenerator and KnativeManifestGenerator: integrate ProgressDeadlineCalculator with the new Scaling-based approach. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chore: delete local claude config .claude/settings.local.json

a554e5c

Pasichniuk reviewed Mar 6, 2026

View reviewed changes

src/main/java/com/epam/aidial/deployment/manager/model/deployment/CreateDeployment.java Outdated Show resolved Hide resolved

Merge branch 'development' into feature/161-scaling-knative-types

6b7d40d

Pasichniuk reviewed Mar 6, 2026

View reviewed changes

src/main/resources/db/migration/H2/V1.47__AddScalingToDeploymentTable.sql Show resolved Hide resolved

refactor: drop deprecated initial_scale/min_scale/max_scale columns

d234f5d

Add DROP COLUMN statements to V1.47 migration for H2, PostgreSQL, and MS SQL Server. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Pasichniuk approved these changes Mar 6, 2026

View reviewed changes

oleksii-donets merged commit d5a5d2a into development Mar 6, 2026
8 checks passed

oleksii-donets deleted the feature/161-scaling-knative-types branch March 6, 2026 11:05

oleksii-donets changed the title ~~feat: support scaling config for knative deployment types~~ feat!: support scaling config for knative deployment types Mar 6, 2026

oleksii-donets changed the title ~~feat!: support scaling config for knative deployment types~~ feat: support scaling config for knative deployment types Mar 6, 2026

Conversation

oleksii-donets commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Applicable issues

Description of changes

Checklist

Uh oh!

ai-dial-actions commented Feb 27, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

ai-dial-actions commented Feb 27, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

ai-dial-actions commented Mar 2, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

Pasichniuk commented Mar 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oleksii-donets commented Mar 2, 2026

Uh oh!

ai-dial-actions commented Mar 2, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

ai-dial-actions commented Mar 2, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

ai-dial-actions commented Mar 3, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

ai-dial-actions commented Mar 4, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

Uh oh!

ai-dial-actions commented Mar 5, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

Scanned Files

Uh oh!

ai-dial-actions commented Mar 5, 2026

Dependency Review

License Issues

settings.gradle

OpenSSF Scorecard

oleksii-donets commented Feb 27, 2026 •

edited

Loading