feat: support direct imageReference for knative deployments#182
Merged
oleksii-donets merged 30 commits intodevelopmentfrom Mar 10, 2026
Merged
feat: support direct imageReference for knative deployments#182oleksii-donets merged 30 commits intodevelopmentfrom
oleksii-donets merged 30 commits intodevelopmentfrom
Conversation
Allow MCP, Adapter, and Interceptor deployments to use either an internal imageDefinitionId or a direct imageReference, reducing deployment friction for pre-built images and preserving backward compatibility. Made-with: Cursor
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Use typed source payloads for MCP/Adapter/Interceptor create and response DTOs so clients use one consistent contract for internal images and direct image references. Move source-to-domain conversion into the mapper to keep request DTOs declarative. Made-with: Cursor
Pasichniuk
reviewed
Mar 2, 2026
...n/java/com/epam/aidial/deployment/manager/dao/entity/deployment/AdapterDeploymentEntity.java
Outdated
Show resolved
Hide resolved
Pasichniuk
reviewed
Mar 2, 2026
src/main/resources/db/migration/H2/V1.47__AddImageReferenceToKnativeDeployments.sql
Outdated
Show resolved
Hide resolved
Return image origin via the nested source object in deployment list responses and remove redundant top-level image definition fields from DeploymentInfoDto. Made-with: Cursor
Made-with: Cursor # Conflicts: # src/main/java/com/epam/aidial/deployment/manager/model/deployment/AdapterDeployment.java # src/main/java/com/epam/aidial/deployment/manager/model/deployment/InterceptorDeployment.java # src/main/java/com/epam/aidial/deployment/manager/web/dto/DeploymentInfoDto.java # src/main/java/com/epam/aidial/deployment/manager/web/dto/deployment/CreateImageBasedDeploymentRequestDto.java # src/main/java/com/epam/aidial/deployment/manager/web/dto/deployment/ImageBasedDeploymentDto.java # src/main/java/com/epam/aidial/deployment/manager/web/mapper/DeploymentDtoMapper.java
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
…ings Prevents MapStruct unmapped-property warnings from failing builds with -Werror after merge-related DTO changes. Made-with: Cursor
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Pasichniuk
reviewed
Mar 3, 2026
...ial/deployment/manager/web/dto/deployment/CreateInternalImageDeploymentSourceRequestDto.java
Outdated
Show resolved
Hide resolved
Pasichniuk
reviewed
Mar 3, 2026
...main/java/com/epam/aidial/deployment/manager/web/dto/deployment/ImageBasedDeploymentDto.java
Show resolved
Hide resolved
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Pasichniuk
reviewed
Mar 5, 2026
...in/java/com/epam/aidial/deployment/manager/model/deployment/CreateInterceptorDeployment.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Please update PR description to reflect fresh changes |
Remove redundant Lombok annotations from empty CreateAdapterDeployment and CreateInterceptorDeployment subclasses. Add isjson check constraint on deployment.source column in MS SQL Server migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Pasichniuk
previously approved these changes
Mar 5, 2026
Collaborator
|
Make sure FE is ready to support new API changes |
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
1fdd50b to
9784456
Compare
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Resolve conflicts: - KnativeDeploymentManager: keep PR's resolveImageName + development's getScaling() - DeploymentInfoDto: add missing imports from development - DeploymentFunctionalTest: keep PR's source-based assertions, drop old scaling assertions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
V1.47 and V1.48 are now taken by development branch migrations (AddScalingToDeploymentTable, CreateDeploymentTopicsTable). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Add feature spec 003-unified-deployment-source with full speckit artifacts (spec, plan, research, data-model, contracts, quickstart, tasks, checklists). Update 7 existing specs to reflect the unified Source sealed interface, source-based image contract for Knative deployments, renamed source classes for Inference/NIM, and schema version bump to V1.49. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…hema V1.49 already exists in the codebase; the unified deployment source migration will use V1.50 instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ent-source' into feat/172-image-reference-knative-sources
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Resolve merge conflicts with command/args support (development): - Removed command/args and source from inference subclasses (both now on base) - Renumbered UnifyDeploymentSource migrations from V1.49 to V1.50 - Updated KnativeDeploymentManagerTest mocks for new serviceConfig signature - Updated create_mcp_deployment_request_with_command_args.json to use source format Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Dependency ReviewThe following issues were found:
Snapshot WarningsRe-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. License Issuessettings.gradle
OpenSSF ScorecardScorecard details
|
Pasichniuk
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
sourcefrom per-type tables (nim_deployment,inference_deployment) and individual columns (image_definition_id,image_definition_type, etc.) into a singlesourceJSON column on the basedeploymenttable.Sourcesealed interface hierarchy (ImageReferenceSource,InternalImageSource,HuggingFaceSource,NgcRegistrySource) in the domain model, replacing scattered fields.imageReferencesource support for Knative deployments (MCP, Adapter, Interceptor), allowing deployments without an image definition.sourceobjects per deployment type (DeploymentSourceDto,NimDeploymentSourceDto,InferenceDeploymentSourceDto).DeploymentDtoMapperto use@SubclassMappingwith@Mapping(target = "source", ignore = true)on base methods, removing redundant concrete mapper methods. Source mapping handled via@AfterMapping.CreateAdapterDeployment,CreateInterceptorDeployment,AdapterDeploymentEntity,InterceptorDeploymentEntity,AdapterDeployment,InterceptorDeployment).isjsoncheck constraint ondeployment.sourcecolumn in MS SQL Server migration.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.