Skip to content

Commit 3e46d50

Browse files
Merge branch 'chore/list-view' of https://github.com/epam/ai-dial-admin-frontend into chore/list-view
2 parents b7040b5 + 8292687 commit 3e46d50

File tree

5 files changed

+26
-21
lines changed

5 files changed

+26
-21
lines changed

apps/ai-dial-admin/src/components/Grid/AgGridWrapper.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import { getColumnsStateFromStorage, GridModel, saveColumnsStateToStorage } from
4343
export interface AgGridProps<T> {
4444
columnDefs?: ColDef[];
4545
rowData?: T[] | null;
46-
additionalGridOptions?: GridOptions;
46+
additionalGridOptions?: Omit<GridOptions, 'columnDefs' | 'rowData' | 'onGridReady'>;
4747
storageKey?: string;
4848
onGridReady?: (gridApi: GridReadyEvent) => void;
4949
}

apps/ai-dial-admin/src/components/SourceField/Template/SelectRunnerModal.tsx

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { DialFormPopup, PopupSize } from '@epam/ai-dial-ui-kit';
2-
import { FC, useState } from 'react';
2+
import { FC, useCallback, useState } from 'react';
33

44
import { SINGLE_ROW_SELECTION } from '@/src/constants/ag-grid';
55
import { BASE_COLUMNS } from '@/src/constants/grid-columns/grid-columns';
@@ -8,7 +8,7 @@ import { useI18n } from '@/src/locales/client';
88
import { InterceptorTemplate } from '@/src/models/interceptor-template';
99

1010
import RadioButtonRenderer from '@/src/components/Grid/CellRenderers/RadioButtonRenderer';
11-
import { GridOptions } from 'ag-grid-community';
11+
import { GridOptions, GridReadyEvent } from 'ag-grid-community';
1212
import GridView from '@/src/components/Grid/GridView/GridView';
1313

1414
interface Props {
@@ -37,15 +37,22 @@ const SelectRunnerModal: FC<Props> = ({ selected, runners, isModalOpen, onClose,
3737
setSelectedRunner(event.data.name);
3838
}
3939
},
40-
onGridReady: (event) => {
40+
};
41+
42+
const onGridReady = useCallback(
43+
(event: GridReadyEvent) => {
44+
event.api?.updateGridOptions({
45+
columnDefs: BASE_COLUMNS,
46+
rowData: runners,
47+
});
4148
event.api.forEachNode((node) => {
4249
if (node.data.name === selectedRunner) {
4350
node.setSelected(true);
4451
}
4552
});
4653
},
47-
};
48-
54+
[runners, selectedRunner],
55+
);
4956
return (
5057
<DialFormPopup
5158
onClose={onClose}
@@ -63,9 +70,8 @@ const SelectRunnerModal: FC<Props> = ({ selected, runners, isModalOpen, onClose,
6370
<div className="flex flex-col px-6 py-4 h-full">
6471
<GridView
6572
emptyDataProps={{ title: t(EntitiesI18nKey.NoTemplates) }}
66-
columnDefs={BASE_COLUMNS}
67-
rowData={runners}
6873
additionalGridOptions={options}
74+
onGridReady={onGridReady}
6975
/>
7076
</div>
7177
</DialFormPopup>

apps/ai-dial-admin/src/utils/deployments/containers.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ export const getContainerRedeploySnapshot = (container: Container): ContainerRed
3737
containerGrpcPort: container.containerGrpcPort,
3838
envs: normalizeEnvironmentVariables(container.metadata?.envs),
3939
resources: normalizeResources(container.resources),
40-
allowedDomains: container.allowedDomains,
4140
};
4241
};
4342

apps/ai-dial-admin/src/utils/deployments/entity.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,12 +72,12 @@ export const getIdFormat = (name: string) => {
7272
return name.toLowerCase().replace(/\s+/g, '_');
7373
};
7474

75-
export const getEntityId = (container: Container, route: ApplicationRoute, t: (key: string) => string) => {
76-
return getIdFormat(getEntityName(container, route, t));
75+
export const getEntityId = (container: Container) => {
76+
return getIdFormat(getEntityName(container));
7777
};
7878

79-
export const getEntityName = (container: Container, route: ApplicationRoute, t: (key: string) => string) => {
80-
return `${container.displayName} ${getTranslatedEntity(route, t)}`;
79+
export const getEntityName = (container: Container) => {
80+
return `${container.displayName}`;
8181
};
8282

8383
export const getEntityTemplate = (
@@ -87,8 +87,8 @@ export const getEntityTemplate = (
8787
transport?: CONTAINER_TRANSPORT,
8888
): DialModel | Toolset | DialInterceptor => {
8989
const template: DialModel | Toolset | DialInterceptor = {
90-
name: getEntityId(container, route, t),
91-
displayName: getEntityName(container, route, t),
90+
name: getEntityId(container),
91+
displayName: getEntityName(container),
9292
description: '',
9393
source: { $type: SOURCE_TYPE.CONTAINER, containerId: container.name },
9494
};
@@ -119,8 +119,8 @@ export const getAssetTemplate = (
119119
transport: CONTAINER_TRANSPORT,
120120
): Partial<AssetToolset> => {
121121
return {
122-
name: getEntityId(container, route, t),
123-
displayName: getEntityName(container, route, t),
122+
name: getEntityId(container),
123+
displayName: getEntityName(container),
124124
endpoint: container.url,
125125
transport: ENTITY_TRANSPORT[transport],
126126
};

apps/ai-dial-admin/src/utils/deployments/tests/entity.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,22 +96,22 @@ describe('entity utils', () => {
9696
describe('getEntityId', () => {
9797
test('generates id based on container name and route', () => {
9898
const container = { displayName: 'MyContainer' } as any;
99-
expect(getEntityId(container, ApplicationRoute.ModelServings, t)).toBe('mycontainer_entities.model');
99+
expect(getEntityId(container)).toBe('mycontainer');
100100
});
101101
});
102102

103103
describe('getEntityName', () => {
104104
test('generates name based on container name and route', () => {
105105
const container = { displayName: 'MyContainer' } as any;
106-
expect(getEntityName(container, ApplicationRoute.ModelServings, t)).toBe(`MyContainer ${EntitiesI18nKey.Model}`);
106+
expect(getEntityName(container)).toBe(`MyContainer`);
107107
});
108108
});
109109

110110
describe('getEntityTemplate', () => {
111111
test('returns basic template', () => {
112112
const container = { displayName: 'MyContainer', name: '123' } as any;
113113
const template = getEntityTemplate(ApplicationRoute.InterceptorContainers, container, t);
114-
expect(template.name).toBe('mycontainer_entities.interceptor');
114+
expect(template.name).toBe('mycontainer');
115115
expect(template.source?.containerId).toBe('123');
116116
});
117117

@@ -134,7 +134,7 @@ describe('entity utils', () => {
134134
test('returns asset template', () => {
135135
const container = { displayName: 'MyContainer', url: 'http://url' } as any;
136136
const template = getAssetTemplate(ApplicationRoute.McpContainers, container, t, CONTAINER_TRANSPORT.SSE);
137-
expect(template.name).toBe('mycontainer_entities.toolset');
137+
expect(template.name).toBe('mycontainer');
138138
expect(template.endpoint).toBe('http://url');
139139
expect(template.transport).toBe(CONTAINER_TRANSPORT.SSE);
140140
});

0 commit comments

Comments
 (0)