Skip to content

Commit 0c3de11

Browse files
committed
Fix stopup & stopdown controls DT_03 & DT_21
1 parent af2c7c1 commit 0c3de11

File tree

2 files changed

+56
-8
lines changed

2 files changed

+56
-8
lines changed

inelsmqtt/protocols/elanrf.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,8 @@ class Command(IntEnum):
188188
SHUTTER_STATE_SET = {
189189
Shutter_state.Open: Command.OPEN,
190190
Shutter_state.Closed: Command.CLOSE,
191+
Shutter_state.Stop_up: Command.STOP_UP,
192+
Shutter_state.Stop_down: Command.STOP_DOWN,
191193
}
192194

193195
@classmethod
@@ -702,6 +704,8 @@ class Command(IntEnum):
702704
SHUTTER_STATE_SET = {
703705
Shutter_state.Open: Command.OPEN,
704706
Shutter_state.Closed: Command.CLOSE,
707+
Shutter_state.Stop_up: Command.STOP_UP,
708+
Shutter_state.Stop_down: Command.STOP_DOWN,
705709
}
706710

707711
@classmethod

tests/test_device_value.py

Lines changed: 52 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,33 @@ def test_create_ha_value_object_closed(self, device_value_closed):
137137
assert isinstance(device_value_closed.ha_value.shutters[0], Shutter)
138138
assert device_value_closed.ha_value.shutters[0].is_closed
139139

140-
def test_format_inels_set_value_open(self, device_value_open):
141-
assert device_value_open.inels_set_value == "01\n00\n00\n"
140+
def test_format_inels_set_value_open(self, device_value_closed):
141+
device_value_closed.ha_value.shutters[0].state = Shutter_state.Open
142+
device_value = self.create_device_value(
143+
ha_value=device_value_closed.ha_value,
144+
)
145+
assert device_value.inels_set_value == "01\n00\n00\n"
146+
147+
def test_format_inels_set_value_closed(self, device_value_open):
148+
device_value_open.ha_value.shutters[0].state = Shutter_state.Closed
149+
device_value = self.create_device_value(
150+
ha_value=device_value_open.ha_value,
151+
)
152+
assert device_value.inels_set_value == "02\n00\n00\n"
142153

143-
def test_format_inels_set_value_closed(self, device_value_closed):
144-
assert device_value_closed.inels_set_value == "02\n00\n00\n"
154+
def test_format_inels_set_value_stop_up(self, device_value_closed):
155+
device_value_closed.ha_value.shutters[0].state = Shutter_state.Stop_up
156+
device_value = self.create_device_value(
157+
ha_value=device_value_closed.ha_value,
158+
)
159+
assert device_value.inels_set_value == "04\n00\n00\n"
160+
161+
def test_format_inels_set_value_stop_down(self, device_value_open):
162+
device_value_open.ha_value.shutters[0].state = Shutter_state.Stop_down
163+
device_value = self.create_device_value(
164+
ha_value=device_value_open.ha_value,
165+
)
166+
assert device_value.inels_set_value == "06\n00\n00\n"
145167

146168
def test_comm_test(self):
147169
device_value = self.create_device_value()
@@ -517,11 +539,33 @@ def test_create_ha_value_object_closed(self, device_value_closed):
517539
assert device_value_closed.ha_value.shutters_with_pos[0].position == 0
518540
assert device_value_closed.ha_value.shutters_with_pos[0].state == 1
519541

520-
def test_format_inels_set_value_open(self, device_value_open):
521-
assert device_value_open.inels_set_value == "01\n00\n00\n"
542+
def test_format_inels_set_value_open(self, device_value_closed):
543+
device_value_closed.ha_value.shutters_with_pos[0].state = Shutter_state.Open
544+
device_value = self.create_device_value(
545+
ha_value=device_value_closed.ha_value,
546+
)
547+
assert device_value.inels_set_value == "01\n00\n00\n"
548+
549+
def test_format_inels_set_value_closed(self, device_value_open):
550+
device_value_open.ha_value.shutters_with_pos[0].state = Shutter_state.Closed
551+
device_value = self.create_device_value(
552+
ha_value=device_value_open.ha_value,
553+
)
554+
assert device_value.inels_set_value == "02\n00\n00\n"
522555

523-
def test_format_inels_set_value_closed(self, device_value_closed):
524-
assert device_value_closed.inels_set_value == "02\n00\n00\n"
556+
def test_format_inels_set_value_stop_up(self, device_value_closed):
557+
device_value_closed.ha_value.shutters_with_pos[0].state = Shutter_state.Stop_up
558+
device_value = self.create_device_value(
559+
ha_value=device_value_closed.ha_value,
560+
)
561+
assert device_value.inels_set_value == "04\n00\n00\n"
562+
563+
def test_format_inels_set_value_stop_down(self, device_value_open):
564+
device_value_open.ha_value.shutters_with_pos[0].state = Shutter_state.Stop_down
565+
device_value = self.create_device_value(
566+
ha_value=device_value_open.ha_value,
567+
)
568+
assert device_value.inels_set_value == "06\n00\n00\n"
525569

526570
def test_format_inels_set_value_open_to_70_percent(self, device_value_closed):
527571
device_value_closed.ha_value.shutters_with_pos[0].set_pos = True

0 commit comments

Comments
 (0)