Bug fix: implement HCA error code handling

Author: epdevlab

inelsmqtt/protocols/cu3.py

@@ -2036,6 +2036,7 @@ class DT_166:
         CONTROL_MODE: [29],
         VIRT_CONTR: [30],
     }
+    ERR_CODES = [0x7FFFFFFF, 0x7FFFFFFE, 0x7FFFFFFD, 0x7FFFFFFC, 0x7FFFFFFB, 0x7FFFFFFA, 0x7FFFFFF9]
 
     @staticmethod
     def create_command_payload(out1: int = 0, out2: int = 0) -> str:
@@ -2049,7 +2050,7 @@ def create_ha_value_object(cls, device_value: DeviceValue) -> Any:
         temp_current: float = twos_comp_4B(
             int(trim_inels_status_values(device_value.inels_status_value, cls.DATA, CURRENT_TEMP, ""), 16)
         )
-        if temp_current == 0x7FFFFFFB:
+        if temp_current in cls.ERR_CODES:
             temp_current = 0
         else:
             temp_current /= 100
@@ -2063,7 +2064,7 @@ def create_ha_value_object(cls, device_value: DeviceValue) -> Any:
         temp_required_heat: float = twos_comp_4B(
             int(trim_inels_status_values(device_value.inels_status_value, cls.DATA, REQUIRED_HEAT_TEMP, ""), 16)
         )
-        if temp_required_heat == 0x7FFFFFFB:
+        if temp_required_heat in cls.ERR_CODES:
             temp_required_heat = 0
             if hasattr(device_value.last_value, "ha_value"):
                 last_known_required = device_value.last_value.ha_value.climate_controller.last_known_required
@@ -2078,7 +2079,7 @@ def create_ha_value_object(cls, device_value: DeviceValue) -> Any:
         temp_required_cool: float = twos_comp_4B(
             int(trim_inels_status_values(device_value.inels_status_value, cls.DATA, REQUIRED_COOL_TEMP, ""), 16)
         )
-        if temp_required_cool == 0x7FFFFFFB:
+        if temp_required_cool in cls.ERR_CODES:
             temp_required_cool = 0
             if hasattr(device_value.last_value, "ha_value"):
                 last_known_required_cool = device_value.last_value.ha_value.climate_controller.last_known_required_cool

setup.py

@@ -4,7 +4,7 @@
 
 setup(
     name="elkoep-mqtt",
-    version="0.2.33.beta.25",
+    version="0.2.33.beta.26",
     url="https://github.com/epdevlab/elkoep-mqtt",
     license="MIT",
     author="Elko EP s.r.o.",

tests/test_device_value.py

@@ -2046,12 +2046,48 @@ def device_value_all_positive(self):
             inels_value="64\n00\n00\n00\nC8\n00\n00\n00\n2C\n01\n00\n00\n90\n01\n00\n00\nF4\n01\n00\n00\n58\n02\n00\n00\nBC\n02\n00\n00\n00\n00\n00\n"
         )
 
+    @pytest.fixture
+    def device_value_7FFFFFFF(self):
+        return self.create_device_value(
+            inels_value="FF\nFF\nFF\n7F\nC8\n00\n00\n00\nFF\nFF\nFF\n7F\n90\n01\n00\n00\nF4\n01\n00\n00\nFF\nFF\nFF\n7F\nBC\n02\n00\n00\n00\n00\n00\n"
+        )
+
+    @pytest.fixture
+    def device_value_7FFFFFFE(self):
+        return self.create_device_value(
+            inels_value="FE\nFF\nFF\n7F\nC8\n00\n00\n00\nFE\nFF\nFF\n7F\n90\n01\n00\n00\nF4\n01\n00\n00\nFE\nFF\nFF\n7F\nBC\n02\n00\n00\n00\n00\n00\n"
+        )
+
+    @pytest.fixture
+    def device_value_7FFFFFFD(self):
+        return self.create_device_value(
+            inels_value="FD\nFF\nFF\n7F\nC8\n00\n00\n00\nFD\nFF\nFF\n7F\n90\n01\n00\n00\nF4\n01\n00\n00\nFD\nFF\nFF\n7F\nBC\n02\n00\n00\n00\n00\n00\n"
+        )
+
+    @pytest.fixture
+    def device_value_7FFFFFFC(self):
+        return self.create_device_value(
+            inels_value="FC\nFF\nFF\n7F\nC8\n00\n00\n00\nFC\nFF\nFF\n7F\n90\n01\n00\n00\nF4\n01\n00\n00\nFC\nFF\nFF\n7F\nBC\n02\n00\n00\n00\n00\n00\n"
+        )
+
     @pytest.fixture
     def device_value_7FFFFFFB(self):
         return self.create_device_value(
             inels_value="FB\nFF\nFF\n7F\nC8\n00\n00\n00\nFB\nFF\nFF\n7F\n90\n01\n00\n00\nF4\n01\n00\n00\nFB\nFF\nFF\n7F\nBC\n02\n00\n00\n00\n00\n00\n"
         )
 
+    @pytest.fixture
+    def device_value_7FFFFFFA(self):
+        return self.create_device_value(
+            inels_value="FA\nFF\nFF\n7F\nC8\n00\n00\n00\nFA\nFF\nFF\n7F\n90\n01\n00\n00\nF4\n01\n00\n00\nFA\nFF\nFF\n7F\nBC\n02\n00\n00\n00\n00\n00\n"
+        )
+
+    @pytest.fixture
+    def device_value_7FFFFFF9(self):
+        return self.create_device_value(
+            inels_value="F9\nFF\nFF\n7F\nC8\n00\n00\n00\nF9\nFF\nFF\n7F\n90\n01\n00\n00\nF4\n01\n00\n00\nF9\nFF\nFF\n7F\nBC\n02\n00\n00\n00\n00\n00\n"
+        )
+
     def test_create_ha_value_object(self, device_value):
         assert device_value.ha_value.climate_controller.current == 27.81
         assert device_value.ha_value.climate_controller.required == 32.0
@@ -2132,11 +2168,41 @@ def test_all_positive_temp(self, device_value_all_positive):
         assert device_value_all_positive.ha_value.climate_controller.required_cool == 6.0
         assert device_value_all_positive.ha_value.climate_controller.correction_temp == 7.0
 
+    def test_7FFFFFFF(self, device_value_7FFFFFFF):
+        assert device_value_7FFFFFFF.ha_value.climate_controller.current == 0
+        assert device_value_7FFFFFFF.ha_value.climate_controller.required == 0
+        assert device_value_7FFFFFFF.ha_value.climate_controller.required_cool == 0
+
+    def test_7FFFFFFE(self, device_value_7FFFFFFE):
+        assert device_value_7FFFFFFE.ha_value.climate_controller.current == 0
+        assert device_value_7FFFFFFE.ha_value.climate_controller.required == 0
+        assert device_value_7FFFFFFE.ha_value.climate_controller.required_cool == 0
+
+    def test_7FFFFFFD(self, device_value_7FFFFFFD):
+        assert device_value_7FFFFFFD.ha_value.climate_controller.current == 0
+        assert device_value_7FFFFFFD.ha_value.climate_controller.required == 0
+        assert device_value_7FFFFFFD.ha_value.climate_controller.required_cool == 0
+
+    def test_7FFFFFFC(self, device_value_7FFFFFFC):
+        assert device_value_7FFFFFFC.ha_value.climate_controller.current == 0
+        assert device_value_7FFFFFFC.ha_value.climate_controller.required == 0
+        assert device_value_7FFFFFFC.ha_value.climate_controller.required_cool == 0
+
     def test_7FFFFFFB(self, device_value_7FFFFFFB):
         assert device_value_7FFFFFFB.ha_value.climate_controller.current == 0
         assert device_value_7FFFFFFB.ha_value.climate_controller.required == 0
         assert device_value_7FFFFFFB.ha_value.climate_controller.required_cool == 0
 
+    def test_7FFFFFFA(self, device_value_7FFFFFFA):
+        assert device_value_7FFFFFFA.ha_value.climate_controller.current == 0
+        assert device_value_7FFFFFFA.ha_value.climate_controller.required == 0
+        assert device_value_7FFFFFFA.ha_value.climate_controller.required_cool == 0
+
+    def test_7FFFFFF9(self, device_value_7FFFFFF9):
+        assert device_value_7FFFFFF9.ha_value.climate_controller.current == 0
+        assert device_value_7FFFFFF9.ha_value.climate_controller.required == 0
+        assert device_value_7FFFFFF9.ha_value.climate_controller.required_cool == 0
+
 
 class Test_CU_DEVICE_TYPE_167(BaseDeviceTestClass):
     DEVICE_TYPE_ID = "167"