COMM_TEST bug fixed

Author: epdevlab

inelsmqtt/discovery.py

@@ -42,7 +42,8 @@ def discovery(self) -> dict[str, list[Device]]:
                 dev_type = d_frags[1]
                 unique_id = d_frags[2]
 
-                command = ProtocolHandlerMapper.get_handler(dev_type).COMM_TEST()
+                handler = ProtocolHandlerMapper.get_handler(dev_type)
+                command = getattr(handler, "COMM_TEST", lambda: None)()
                 if command:
                     self.__mqtt.publish("inels/set/" + d, command)
                     _LOGGER.info("Sending comm test to device of type %s, unique_id %s", dev_type, unique_id)

inelsmqtt/utils/core.py

@@ -167,7 +167,7 @@ def __update_inels_value(self) -> None:
         try:
             if self.__ha_value is not DUMMY_VAL:
                 if self.__ha_value is None:
-                    self.__inels_set_value = self.device_class.COMM_TEST()
+                    self.__inels_set_value = getattr(self.device_class, "COMM_TEST", lambda: "")()
                 else:
                     self.__inels_set_value = self.device_class.create_inels_set_value(self)
         except Exception as e:

setup.py

@@ -4,7 +4,7 @@
 
 setup(
     name="elkoep-mqtt",
-    version="0.2.33.beta.3",
+    version="0.2.33.beta.4",
     url="https://github.com/epdevlab/elkoep-mqtt",
     license="MIT",
     author="Elko EP s.r.o.",

tests/test_discovery.py

@@ -34,6 +34,34 @@ def test_discovery_successful(mqtt_mock, discovery):
     mqtt_mock.discovery_all.assert_called_once()
 
 
+def test_discovery_class_com_test(mqtt_mock, discovery):
+    """Test discovery of devices when the handler has a COMM_TEST method."""
+    mqtt_mock.discovery_all.return_value = {
+        "10e97f8b7d30/01/19E8": None,
+        "10e97f8b7d30/02/30E8": None,
+    }
+    expected_devices = []
+
+    discovered_devices = discovery.discovery()
+    assert len(discovered_devices) == len(expected_devices)
+    assert mqtt_mock.discovery_all.call_count == 2
+
+
+def test_discovery_class_without_com_test(mqtt_mock, discovery):
+    """Test discovery of devices when the handler does not have a COMM_TEST method."""
+    mqtt_mock.discovery_all.return_value = {
+        "2C6A6F1036B3/108/02A89F": None,
+        "2C6A6F1036B3/101/0294DD": None,
+        "10e97f8b7d30/17/19E8": None,
+        "10e97f8b7d30/30/30E8": None,
+    }
+    expected_devices = []
+
+    discovered_devices = discovery.discovery()
+    assert len(discovered_devices) == len(expected_devices)
+    mqtt_mock.discovery_all.assert_called_once()
+
+
 def test_discovery_with_retry(mqtt_mock, discovery):
     """Test discovery with retry logic when initial discovery fails."""
     mqtt_mock.discovery_all.side_effect = [