Bug fix: As a result of parsing device values, DUMMY_VAL may be set, which causes ha_diff to fail.

Author: epdevlab

inelsmqtt/devices/__init__.py

@@ -18,7 +18,7 @@
     TOPIC_FRAGMENTS,
     VERSION,
 )
-from inelsmqtt.utils.core import DeviceClassProtocol, DeviceTypeNotFound, DeviceValue, ProtocolHandlerMapper
+from inelsmqtt.utils.core import DUMMY_VAL, DeviceClassProtocol, DeviceTypeNotFound, DeviceValue, ProtocolHandlerMapper
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -335,6 +335,9 @@ def ha_diff(self, last_val: Any, curr_val: Any) -> None:
         if self.__entity_callbacks is None:
             return
 
+        if last_val is DUMMY_VAL or curr_val is DUMMY_VAL:
+            return
+
         for k, curr_value in curr_val.__dict__.items():
             if k.startswith("_"):
                 continue

setup.py

@@ -4,7 +4,7 @@
 
 setup(
     name="elkoep-mqtt",
-    version="0.2.33.beta.8",
+    version="0.2.33.beta.9",
     url="https://github.com/epdevlab/elkoep-mqtt",
     license="MIT",
     author="Elko EP s.r.o.",

tests/test_device.py

@@ -9,6 +9,7 @@
 )
 from inelsmqtt.devices import Device, DeviceInfo
 from inelsmqtt.utils.common import SimpleRelay, WarmLight, new_object
+from inelsmqtt.utils.core import DUMMY_VAL
 
 TEST_STATE_TOPIC = "inels/status/10e97f8b7d30/02/02E8"
 
@@ -205,3 +206,37 @@ def test_ha_diff_plain(device):
     callback_low_battery.assert_not_called()
     callback_temp_in.assert_called_once()
     callback_temp_out.assert_not_called()
+
+
+def test_ha_diff_dummy_val(device):
+    callback_low_battery = MagicMock()
+    callback_temp_in = MagicMock()
+    callback_temp_out = MagicMock()
+
+    device.add_ha_callback("low_battery", -1, callback_low_battery)
+    device.add_ha_callback("temp_in", -1, callback_temp_in)
+    device.add_ha_callback("temp_out", -1, callback_temp_out)
+
+    curr_val = new_object(
+        low_battery=True,
+        temp_in=2250,
+        temp_out=2000,
+    )
+
+    # Test when last_val is DUMMY_VAL
+    device.ha_diff(DUMMY_VAL, curr_val)
+    callback_low_battery.assert_not_called()
+    callback_temp_in.assert_not_called()
+    callback_temp_out.assert_not_called()
+
+    # Test when curr_val is DUMMY_VAL
+    device.ha_diff(curr_val, DUMMY_VAL)
+    callback_low_battery.assert_not_called()
+    callback_temp_in.assert_not_called()
+    callback_temp_out.assert_not_called()
+
+    # Test when both values are DUMMY_VAL
+    device.ha_diff(DUMMY_VAL, DUMMY_VAL)
+    callback_low_battery.assert_not_called()
+    callback_temp_in.assert_not_called()
+    callback_temp_out.assert_not_called()