ss: PR ethersphere#1731. Comments on public Utils methods.

Removed unused method in crypto.go

Author: kortatu

pss/crypto/crypto.go

@@ -194,24 +194,6 @@ func (msg *receivedMessage) validateAndParse() error {
 	return nil
 }
 
-// sigToPubKey returns the public key associated to the message's signature.
-// should only be called if message has been signed
-func (msg *receivedMessage) sigToPubKey() *ecdsa.PublicKey {
-	defer func() { recover() }() // in case of invalid signature
-
-	signedBytes := msg.Raw
-	if isMessageSigned(msg.Raw[0]) {
-		sz := len(msg.Raw) - signatureLength
-		signedBytes = msg.Raw[:sz]
-	}
-	pub, err := msg.crypto.sigToPub(signedBytes, msg.Signature)
-	if err != nil {
-		log.Error("failed to recover public key from signature", "err", err)
-		return nil
-	}
-	return pub
-}
-
 func newReceivedMessage(decrypted []byte, salt []byte, crypto *defaultCryptoBackend) *receivedMessage {
 	return &receivedMessage{
 		Raw:          decrypted,

pss/crypto/utils.go

@@ -41,6 +41,7 @@ func NewUtils() Utils {
 	}
 }
 
+// Generates a new private key right away. It is not stored for later retrieval.
 func (utils *utils) GenerateKey() (*ecdsa.PrivateKey, error) {
 	return ethCrypto.GenerateKey()
 }
@@ -74,6 +75,7 @@ func (utils *utils) NewKeyPair() (string, error) {
 	return id, nil
 }
 
+// GetPrivateKey return a PrivateKey previously generated in NewKeyPair by id
 func (utils *utils) GetPrivateKey(id string) (*ecdsa.PrivateKey, error) {
 	utils.keyMu.RLock()
 	defer utils.keyMu.RUnlock()