minor change

Author: aperonam

pss/outbox/outbox_test.go

@@ -7,13 +7,10 @@ import (
 	"time"
 )
 
-type testMsg struct {
-}
-
 func TestMessageOutbox(t *testing.T) {
 
-	outboxCapacity := 2
 	successC := make(chan struct{})
+	outboxCapacity := 2
 	forward := func(msg interface{}) error {
 		successC <- struct{}{}
 		return nil
@@ -24,12 +21,11 @@ func TestMessageOutbox(t *testing.T) {
 		QuitC:       nil,
 		Forward:     forward,
 	})
-
-	outboxMessage := NewOutboxMessage(testMsg{})
+	testMessage := outboxTestMessage()
 
 	go outbox.ProcessOutbox()
 
-	err := outbox.Enqueue(outboxMessage)
+	err := outbox.Enqueue(testMessage)
 	if err != nil {
 		t.Fatalf("expected no error, got %v", err)
 	}
@@ -57,7 +53,7 @@ func TestMessageOutbox(t *testing.T) {
 
 	outbox.forward = failedForward
 
-	err = outbox.Enqueue(outboxMessage)
+	err = outbox.Enqueue(testMessage)
 	if err != nil {
 		t.Fatalf("Expected no error enqueing, got %v", err.Error())
 	}
@@ -99,19 +95,21 @@ func TestOutboxFull(t *testing.T) {
 		QuitC:       nil,
 		Forward:     succesForward,
 	})
+	testMessage := outboxTestMessage()
+
 	go outbox.ProcessOutbox()
 
-	err := outbox.Enqueue(outboxTestMessage())
+	err := outbox.Enqueue(testMessage)
 	if err != nil {
 		t.Fatalf("expected no error enqueing first message, got %v", err)
 	}
-	err = outbox.Enqueue(outboxTestMessage())
+	err = outbox.Enqueue(testMessage)
 	if err != nil {
 		t.Fatalf("expected no error enqueing second message, got %v", err)
 	}
 	//As we haven't signaled procChan, the messages are still in the outbox
 
-	err = outbox.Enqueue(outboxTestMessage())
+	err = outbox.Enqueue(testMessage)
 	if err == nil {
 		t.Fatalf("expected error enqueing third message, instead got nil")
 	}