Add System tests (#32)

* first pass of system test (not working)

* fully working "attach" system test

* linting

* add a detach system test

* split up the system test file

* add CLI system tests

* add CLI system tests

* add more CLI system tests

Author: gilesknap

src/usb_remote/client.py

@@ -13,21 +13,23 @@
     detach_command,
     find_command,
 )
-from .config import SERVER_PORT, get_timeout
+from .config import get_server_port, get_timeout
 from .port import Port
 from .usbdevice import DeviceNotFoundError, MultipleDevicesError, UsbDevice
 from .utility import run_command
 
 logger = logging.getLogger(__name__)
 
+# Will be fetched from config when needed
+SERVER_PORT = None
 # Default connection timeout in seconds
 DEFAULT_TIMEOUT = 2.0
 
 
 def send_request(
     request: ListRequest | DeviceRequest,
     server_host: str = "localhost",
-    server_port: int = SERVER_PORT,
+    server_port: int | None = None,
     timeout: float | None = None,
 ) -> ListResponse | DeviceResponse:
     """
@@ -49,6 +51,9 @@ def send_request(
         TimeoutError: If connection or receive times out
         OSError: If connection fails
     """
+    if server_port is None:
+        server_port = get_server_port()
+
     logger.debug(f"Connecting to server at {server_host}:{server_port}")
 
     if timeout is None:

src/usb_remote/config.py

@@ -22,6 +22,7 @@ class UsbRemoteConfig(BaseModel):
     servers: list[str] = Field(default_factory=list)
     server_ranges: list[str] = Field(default_factory=list)
     timeout: float = Field(default=DEFAULT_TIMEOUT, gt=0)
+    server_port: int = Field(default=SERVER_PORT)
     model_config = ConfigDict(extra="forbid")
 
     @classmethod
@@ -183,6 +184,17 @@ def get_timeout() -> float:
     return config.timeout
 
 
+def get_server_port() -> int:
+    """
+    Read server port from config file.
+
+    Returns:
+        Server port number. Returns default if not configured.
+    """
+    config = get_config()
+    return config.server_port
+
+
 def save_servers(servers: list[str]) -> None:
     """
     Save list of server addresses to config file.

src/usb_remote/server.py

@@ -1,4 +1,5 @@
 import logging
+import os
 import socket
 import threading
 from typing import Literal
@@ -29,8 +30,11 @@
 
 
 class CommandServer:
-    def __init__(self, host: str = "0.0.0.0", port: int = SERVER_PORT):
+    def __init__(self, host: str = "0.0.0.0", port: int | None = None):
         self.host = host
+        # Allow server port to be overridden via environment variable
+        if port is None:
+            port = int(os.environ.get("USB_REMOTE_SERVER_PORT", SERVER_PORT))
         self.port = port
         self.server_socket = None
         self.running = False

tests/conftest.py

@@ -9,6 +9,9 @@
 from usb_remote.config import UsbRemoteConfig
 from usb_remote.usbdevice import UsbDevice
 
+# Load system integration test fixtures from conftest_system.py
+pytest_plugins = ["tests.conftest_system"]
+
 
 @pytest.fixture
 def mock_config():