Clean MSVC warnings

Author: daneos

asApp/src/asVerify.c

@@ -91,7 +91,7 @@ int main(int argc, char **argv)
         fclose(fp);
         return (-1);
     }
-    while (!feof(fp) && (n = fread(s, 1, BUF_SIZE, fp))) { fwrite(s, 1, n, ftmp); }
+    while (!feof(fp) && (n = (int)fread(s, 1, BUF_SIZE, fp))) { fwrite(s, 1, n, ftmp); }
     fclose(fp);
     fp = NULL;
 

asApp/src/dbrestore.c

@@ -124,7 +124,7 @@ float mySafeDoubleToFloat(double d)
         if (d > 0.0) f = FLT_MIN;
         else f = -FLT_MIN;
     } else {
-        f = d;
+        f = (float)d;
     }
     return (f);
 }
@@ -290,7 +290,7 @@ STATIC long scalar_restore(int pass, DBENTRY *pdbentry, char *PVname, char *valu
                 status = dbNameToAddr(PVname, paddr);
                 if (!status) {
                     if (is_long_string && paddr->field_type == DBF_CHAR) {
-                        status = dbPut(paddr, DBF_CHAR, value_string, strlen(value_string) + 1);
+                        status = dbPut(paddr, DBF_CHAR, value_string, (long)strlen(value_string) + 1);
                     } else {
                         status = dbPut(paddr, DBF_STRING, value_string, 1);
                     }
@@ -947,7 +947,7 @@ int reboot_restore(char *filename, initHookState init_state)
                             printf("                         ebuffer='%s'\n", ebuffer);
                         }
                     }
-                    n = BUF_SIZE - strlen(value_string) - 1;
+                    n = BUF_SIZE - (int)strlen(value_string) - 1;
                     strncat(value_string, bp, n);
                     /* make sure value_string is properly null-terminated */
                     value_string[BUF_SIZE - 1] = '\0';
@@ -1508,7 +1508,7 @@ void makeAutosaveFileFromDbInfo(char *fileBaseName, char *info_name)
                         for (pend = pbegin; *pend && !isspace((int)*pend); pend++) {}
                         /* pend points to whitespace or \0 */
 
-                        flen = pend - pbegin;
+                        flen = (int)(pend - pbegin);
                         if (flen >= sizeof(field) - 1) flen = sizeof(field) - 1;
                         memcpy(field, pbegin, flen);
                         field[flen] = '\0';

asApp/src/os/WIN32/osdNfs.h

@@ -15,6 +15,7 @@
 
 /* definition except for vxWorks */
 #define OK 0
+#undef ERROR /* ERROR is defined by Windows in wingdi.h */
 #define ERROR -1
 #define logMsg errlogPrintf
 

asApp/src/save_restore.c

@@ -178,6 +178,7 @@
 #define SET_FILE_PERMISSIONS 1
 
 #ifdef _WIN32
+#undef SET_FILE_PERMISSIONS
 #define SET_FILE_PERMISSIONS 0
 #endif
 
@@ -598,7 +599,7 @@ STATIC void on_change_timer(CALLBACK *pcallback)
 STATIC void on_change_save(struct event_handler_args event)
 {
     struct chlist *plist;
-    if (save_restoreDebug >= 10) { logMsg("on_change_save: event.usr=0x%lx\n", (unsigned long)event.usr); }
+    if (save_restoreDebug >= 10) { logMsg("on_change_save: event.usr=0x%llx\n", (unsigned long long)event.usr); }
     plist = (struct chlist *)event.usr;
 
     if (plist) {
@@ -2362,7 +2363,7 @@ STATIC int create_data_set(char *filename,              /* save set request file
 	while ((plist->save_file[inx] != 0) && (plist->save_file[inx] != '.') && (inx < (FN_LEN-6))) inx++;
 #else
     /* fix bfr 2007-10-01: need to search for last '.', not first */
-    inx = strlen(plist->save_file) - 1;
+    inx = (int)strlen(plist->save_file) - 1;
     while (inx > 0 && plist->save_file[inx] != '.') inx--;
 #endif
     plist->save_file[inx] = 0; /* truncate if necessary to leave room for ".sav" + null */
@@ -2502,8 +2503,8 @@ int set_requestfile_path(char *path, char *pathsub)
     char fullpath[MAX_PATH_LEN + 1] = "";
     int path_len = 0, pathsub_len = 0;
 
-    if (path && *path) path_len = strlen(path);
-    if (pathsub && *pathsub) pathsub_len = strlen(pathsub);
+    if (path && *path) path_len = (int)strlen(path);
+    if (pathsub && *pathsub) pathsub_len = (int)strlen(pathsub);
     if (path_len + pathsub_len > (MAX_PATH_LEN - 1)) { /* may have to add '/' */
         printf("save_restore:set_requestfile_path: 'path'+'pathsub' is too long\n");
         return (ERROR);
@@ -3294,7 +3295,7 @@ STATIC int do_manual_restore(char *filename, int file_type, char *macrostring)
                     if (bp[strlen(bp) - 1] != '\n') {
                         /* No, we didn't.  One more read will certainly accumulate a value string of length BUF_SIZE */
                         bp = fgets(buffer, BUF_SIZE, inp_fd);
-                        n = BUF_SIZE - strlen(value_string) - 1;
+                        n = BUF_SIZE - (int)strlen(value_string) - 1;
                         strncat(value_string, bp, n);
                         if (value_string[strlen(value_string) - 1] == '\n')
                             value_string[strlen(value_string) - 1] = '\0';
@@ -3308,7 +3309,7 @@ STATIC int do_manual_restore(char *filename, int file_type, char *macrostring)
                     } else if (ca_pend_io(0.5) != ECA_NORMAL) {
                         num_errs++;
                         /* Don't forget trailing null character: "strlen(value_string)+1" below */
-                    } else if (ca_array_put(DBR_CHAR, strlen(value_string) + 1, chanid, value_string) != ECA_NORMAL) {
+                    } else if (ca_array_put(DBR_CHAR, (unsigned long)strlen(value_string) + 1, chanid, value_string) != ECA_NORMAL) {
                         printf("save_restore:do_manual_restore: ca_array_put of '%s' to '%s' failed\n", value_string,
                                PVname);
                         num_errs++;

asApp/src/verify.c

@@ -334,7 +334,7 @@ int do_asVerify_fp(FILE *fp, int verbose, int debug, int write_restore_file, cha
                             /* No, we didn't.  One more read will certainly accumulate a value string of length BUF_SIZE */
                             if (debug > 3) printf("did not reach end of line for long-string PV\n");
                             bp = fgets(s, BUF_SIZE, fp);
-                            n = BUF_SIZE - strlen(value_string) - 1;
+                            n = BUF_SIZE - (int)strlen(value_string) - 1;
                             strncat(value_string, bp, n);
                             if (value_string[strlen(value_string) - 1] == '\n')
                                 value_string[strlen(value_string) - 1] = '\0';
@@ -376,7 +376,7 @@ int do_asVerify_fp(FILE *fp, int verbose, int debug, int write_restore_file, cha
                         if (different || (verbose > 0)) {
                             WRITE_HEADER;
                             if (is_scalar || is_long_string) {
-                                nspace = 24 - strlen(value_string);
+                                nspace = 24 - (int)strlen(value_string);
                                 if (nspace < 1) nspace = 1;
                                 printf("%s%-24s '%s'%*s'%s'\n", different ? "*** " : "    ", PVname, value_string,
                                        nspace, "", svalue);
@@ -461,7 +461,7 @@ static float safeDoubleToFloat(double d)
         if (d > 0.0) f = FLT_MIN;
         else f = -FLT_MIN;
     } else {
-        f = d;
+        f = (float)d;
     }
     return (f);
 }