Skip to content

Commit 38fbdf3

Browse files
committed
update lint config and handle some errors
1 parent e70fee5 commit 38fbdf3

File tree

8 files changed

+30
-11
lines changed

8 files changed

+30
-11
lines changed

app/components/progress-bar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ function EpicProgress() {
2222
.getAnimations()
2323
.map(({ finished }) => finished)
2424

25-
Promise.allSettled(animationPromises).then(() => {
25+
void Promise.allSettled(animationPromises).then(() => {
2626
if (!delayedPending) setAnimationComplete(true)
2727
})
2828
}, [delayedPending])

app/entry.client.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { startTransition } from 'react'
33
import { hydrateRoot } from 'react-dom/client'
44

55
if (ENV.MODE === 'production' && ENV.SENTRY_DSN) {
6-
import('./utils/monitoring.client.tsx').then(({ init }) => init())
6+
void import('./utils/monitoring.client.tsx').then(({ init }) => init())
77
}
88

99
startTransition(() => {

app/entry.server.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,12 @@ export function handleError(
103103
}
104104
if (error instanceof Error) {
105105
console.error(chalk.red(error.stack))
106-
Sentry.captureRemixServerException(error, 'remix.server', request, true)
106+
void Sentry.captureRemixServerException(
107+
error,
108+
'remix.server',
109+
request,
110+
true,
111+
)
107112
} else {
108113
console.error(chalk.red(error))
109114
Sentry.captureException(error)

app/routes/_auth+/auth.$provider.callback.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ test(`when a user is logged in and has already connected, it doesn't do anything
9898
})
9999
const response = await loader({ request, params: PARAMS, context: {} })
100100
expect(response).toHaveRedirect('/settings/profile/connections')
101-
expect(response).toSendToast(
101+
await expect(response).toSendToast(
102102
expect.objectContaining({
103103
title: 'Already Connected',
104104
description: expect.stringContaining(githubUser.profile.login),

app/utils/db.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,6 @@ export const prisma = remember('prisma', () => {
3131
const dur = chalk[color](`${e.duration}ms`)
3232
console.info(`prisma:query - ${dur} - ${e.query}`)
3333
})
34-
client.$connect()
34+
void client.$connect()
3535
return client
3636
})

package-lock.json

Lines changed: 15 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

server/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const IS_DEV = MODE === 'development'
1919
const ALLOW_INDEXING = process.env.ALLOW_INDEXING !== 'false'
2020

2121
if (IS_PROD && process.env.SENTRY_DSN) {
22-
import('./utils/monitoring.js').then(({ init }) => init())
22+
void import('./utils/monitoring.js').then(({ init }) => init())
2323
}
2424

2525
const viteDevServer = IS_PROD

tests/e2e/onboarding.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,10 @@ test('completes onboarding after GitHub OAuth given valid user details', async (
163163
// fields are pre-populated for the user, so we only need to accept
164164
// terms of service and hit the 'crete an account' button
165165
const usernameInput = page.getByRole('textbox', { name: /username/i })
166-
expect(usernameInput).toHaveValue(normalizeUsername(ghUser.profile.login))
167-
expect(page.getByRole('textbox', { name: /^name/i })).toHaveValue(
166+
await expect(usernameInput).toHaveValue(
167+
normalizeUsername(ghUser.profile.login),
168+
)
169+
await expect(page.getByRole('textbox', { name: /^name/i })).toHaveValue(
168170
ghUser.profile.name,
169171
)
170172
const createAccountButton = page.getByRole('button', {

0 commit comments

Comments
 (0)