Improve GitHub OAuth configuration and environment variable handling

- Add null checks for GitHub OAuth strategy configuration
- Make GitHub-related environment variables optional
- Update auth strategy initialization to handle missing credentials gracefully

Author: kentcdodds

app/utils/auth.server.ts

@@ -19,7 +19,10 @@ export const sessionKey = 'sessionId'
 export const authenticator = new Authenticator<ProviderUser>()
 
 for (const [providerName, provider] of Object.entries(providers)) {
-	authenticator.use(provider.getAuthStrategy(), providerName)
+	const strategy = provider.getAuthStrategy()
+	if (strategy) {
+		authenticator.use(strategy, providerName)
+	}
 }
 
 export async function getUserId(request: Request) {

app/utils/env.server.ts

@@ -8,15 +8,16 @@ const schema = z.object({
 	INTERNAL_COMMAND_TOKEN: z.string(),
 	HONEYPOT_SECRET: z.string(),
 	CACHE_DATABASE_PATH: z.string(),
-	// If you plan on using Sentry, uncomment this line
-	// SENTRY_DSN: z.string(),
-	// If you plan to use Resend, uncomment this line
-	// RESEND_API_KEY: z.string(),
-	// If you plan to use GitHub auth, remove the default:
-	GITHUB_CLIENT_ID: z.string().default('MOCK_GITHUB_CLIENT_ID'),
-	GITHUB_CLIENT_SECRET: z.string().default('MOCK_GITHUB_CLIENT_SECRET'),
-	GITHUB_REDIRECT_URI: z.string().default('MOCK_GITHUB_REDIRECT_URI'),
-	GITHUB_TOKEN: z.string().default('MOCK_GITHUB_TOKEN'),
+	// If you plan on using Sentry, remove the .optional()
+	SENTRY_DSN: z.string().optional(),
+	// If you plan to use Resend, remove the .optional()
+	RESEND_API_KEY: z.string().optional(),
+	// If you plan to use GitHub auth, remove the .optional()
+	GITHUB_CLIENT_ID: z.string().optional(),
+	GITHUB_CLIENT_SECRET: z.string().optional(),
+	GITHUB_REDIRECT_URI: z.string().optional(),
+	GITHUB_TOKEN: z.string().optional(),
+
 	ALLOW_INDEXING: z.enum(['true', 'false']).optional(),
 
 	// Tigris Object Storage Configuration

app/utils/providers/github.server.ts

@@ -42,6 +42,16 @@ const GitHubUserResponseSchema = z.object({
 
 export class GitHubProvider implements AuthProvider {
 	getAuthStrategy() {
+		if (
+			!process.env.GITHUB_CLIENT_ID ||
+			!process.env.GITHUB_CLIENT_SECRET ||
+			!process.env.GITHUB_REDIRECT_URI
+		) {
+			console.log(
+				'GitHub OAuth strategy not available because environment variables are not set',
+			)
+			return null
+		}
 		return new GitHubStrategy(
 			{
 				clientId: process.env.GITHUB_CLIENT_ID,

app/utils/providers/provider.ts

@@ -11,7 +11,7 @@ export type ProviderUser = {
 }
 
 export interface AuthProvider {
-	getAuthStrategy(): Strategy<ProviderUser, any>
+	getAuthStrategy(): Strategy<ProviderUser, any> | null
 	handleMockAction(request: Request): Promise<void>
 	resolveConnectionData(
 		providerId: string,