fix getDomainUrl to determine protocol via header

kentcdodds · kentcdodds · commit 4d7a674bb923 · 2024-05-21T09:04:52.000-06:00
diff --git a/app/utils/misc.tsx b/app/utils/misc.tsx
@@ -67,7 +67,7 @@ export function getDomainUrl(request: Request) {
 		request.headers.get('X-Forwarded-Host') ??
 		request.headers.get('host') ??
 		new URL(request.url).host
-	const protocol = host.includes('localhost') ? 'http' : 'https'
+	const protocol = request.headers.get('X-Forwarded-Proto') ?? 'http'
 	return `${protocol}://${host}`
 }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ export function getDomainUrl(request: Request) {`
`67`	`67`	`request.headers.get('X-Forwarded-Host') ??`
`68`	`68`	`request.headers.get('host') ??`
`69`	`69`	`new URL(request.url).host`
`70`		`- const protocol = host.includes('localhost') ? 'http' : 'https'`
	`70`	`+ const protocol = request.headers.get('X-Forwarded-Proto') ?? 'http'`
`71`	`71`	return `${protocol}://${host}`
`72`	`72`	`}`
`73`	`73`