Skip to content

Commit cdb263d

Browse files
committed
test: adjust user menu locators in tests
1 parent 10235b4 commit cdb263d

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

tests/e2e/2fa.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ test('Users can add 2FA to their account and use it when logging in', async ({
3636
await expect(main).toHaveText(/You have enabled two-factor authentication./i)
3737
await expect(main.getByRole('link', { name: /disable 2fa/i })).toBeVisible()
3838

39-
await page.getByRole('link', { name: user.name ?? user.username }).click()
39+
await page.getByRole('link', { name: 'User menu' }).click()
4040
await page.getByRole('menuitem', { name: /logout/i }).click()
4141
await expect(page).toHaveURL(`/`)
4242

@@ -58,7 +58,5 @@ test('Users can add 2FA to their account and use it when logging in', async ({
5858

5959
await page.getByRole('button', { name: /submit/i }).click()
6060

61-
await expect(
62-
page.getByRole('link', { name: user.name ?? user.username }),
63-
).toBeVisible()
61+
await expect(page.getByRole('link', { name: 'User menu' })).toBeVisible()
6462
})

tests/e2e/onboarding.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,12 @@ test('onboarding with link', async ({ page, getOnboardingData }) => {
9999

100100
await expect(page).toHaveURL(`/`)
101101

102-
await page.getByRole('link', { name: onboardingData.name }).click()
102+
await page.getByRole('link', { name: 'User menu' }).click()
103103
await page.getByRole('menuitem', { name: /profile/i }).click()
104104

105105
await expect(page).toHaveURL(`/users/${onboardingData.username}`)
106106

107-
await page.getByRole('link', { name: onboardingData.name }).click()
107+
await page.getByRole('link', { name: 'User menu' }).click()
108108
await page.getByRole('menuitem', { name: /logout/i }).click()
109109
await expect(page).toHaveURL(`/`)
110110
})
@@ -332,7 +332,7 @@ test('login as existing user', async ({ page, insertNewUser }) => {
332332
await page.getByRole('button', { name: /log in/i }).click()
333333
await expect(page).toHaveURL(`/`)
334334

335-
await expect(page.getByRole('link', { name: user.name })).toBeVisible()
335+
await expect(page.getByRole('link', { name: 'User menu' })).toBeVisible()
336336
})
337337

338338
test('reset password with a link', async ({ page, insertNewUser }) => {
@@ -386,7 +386,7 @@ test('reset password with a link', async ({ page, insertNewUser }) => {
386386

387387
await expect(page).toHaveURL(`/`)
388388

389-
await expect(page.getByRole('link', { name: user.name })).toBeVisible()
389+
await expect(page.getByRole('link', { name: 'User menu' })).toBeVisible()
390390
})
391391

392392
test('reset password with a short code', async ({ page, insertNewUser }) => {

tests/e2e/passkey.test.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ test('Users can register and use passkeys', async ({ page, login }) => {
5353
).toHaveLength(1)
5454

5555
// Logout
56-
await page.getByRole('link', { name: user.name ?? user.username }).click()
56+
await page.getByRole('link', { name: 'User menu' }).click()
5757
await page.getByRole('menuitem', { name: /logout/i }).click()
5858
await expect(page).toHaveURL(`/`)
5959

@@ -76,9 +76,7 @@ test('Users can register and use passkeys', async ({ page, login }) => {
7676
await Promise.race([passkeyAssertedPromise, errorPromise])
7777

7878
// Verify successful login
79-
await expect(
80-
page.getByRole('link', { name: user.name ?? user.username }),
81-
).toBeVisible()
79+
await expect(page.getByRole('link', { name: 'User menu' })).toBeVisible()
8280

8381
// Verify the sign count increased
8482
const afterLoginCredentials = await client.send('WebAuthn.getCredentials', {

0 commit comments

Comments
 (0)