Skip to content

Conversation

@isimmons
Copy link
Contributor

This PR updates remix-utils to v8. It fixes pnpm unmet peer dependency warning caused by v7.7.0 React version constraint. Updated Here

List of changes:

  • Updates the remix-utils package to v ^8.0.0
  • Adds the necessary await for all uses of honeypot.check(), honeypot.getInputProps(), and the checkHoneypot util,
    according to the v7-to-v8 upgrade docs
  • Removes the unnecessary crypto-js package.
  • Adds the @oslojs/crypto and @oslojs/encoding packages.

Test Plan

I manually tested in the browser on the following list of public facing forms.

  • signup
  • verify
  • login
  • forgot-password

When filling in the hidden inputs via chrome devtools, I get the correct thrown Response from honeypot.server.ts.
When not filling out the hidden inputs, the form works as expected.

I did not add any automated tests because I'm not sure how I can locate hidden fields to fill them out but I can try this week if you want me to.

Let me know if I need to include anything else. Criticism welcome. I'm new to this PR stuff.

Thanks

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@kentcdodds kentcdodds merged commit a6701ec into epicweb-dev:main Jan 19, 2025
5 checks passed
@isimmons isimmons deleted the pr/update-remix-utils branch January 19, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants