Skip to content

remove samplerate, as it is superseded by tracesSampler #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2025
Merged

remove samplerate, as it is superseded by tracesSampler #960

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04890d5
remove tracesSamplerate, as it is superseded by tracesSampler
zwhitchcox Mar 7, 2025
45ed95e
Merge branch 'main' into pr/remove-duplicate-samplerate
kentcdodds Mar 22, 2025
4a71fd8
preserve prod check
kentcdodds Mar 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions server/utils/monitoring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export function init() {
Sentry.init({
dsn: process.env.SENTRY_DSN,
environment: process.env.NODE_ENV,
tracesSampleRate: process.env.NODE_ENV === 'production' ? 1 : 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to move this prod check to the tracesSampler function

denyUrls: [
/\/resources\/healthcheck/,
// TODO: be smarter about the public assets...
Expand All @@ -33,7 +32,7 @@ export function init() {
if (samplingContext.request?.url?.includes('/resources/healthcheck')) {
return 0
}
return 1
return process.env.NODE_ENV === 'production' ? 1 : 0
},
beforeSendTransaction(event) {
// ignore all healthcheck related transactions
Expand Down
Loading