Skip to content

Commit e82bb3b

Browse files
committed
feedback update
1 parent ee179ee commit e82bb3b

File tree

2 files changed

+8
-11
lines changed
  • exercises/02.metadata

2 files changed

+8
-11
lines changed

exercises/02.metadata/01.problem.styling/app/root.tsx

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,19 +7,16 @@ import {
77
ScrollRestoration,
88
} from 'react-router'
99
import { type Route } from './+types/root'
10+
import tailwindStylesheet from './app.css?url'
1011
import { EpicShop } from './epicshop'
1112

1213
export const links: Route.LinksFunction = () => [
13-
/**
14-
* 🐨 This exercise will let us learn how to use the links export and it's strengths while working
15-
* with meta-data!
16-
*
17-
* 🐨 To get us started add the styles into your project that are already prepared for you!
18-
* 🐨 Then after you're done with that you can add fonts inside of here!
19-
*
20-
* 💰 this is the link to the fonts we want to use:
21-
* https://fonts.googleapis.com/css2?family=Inter:ital,opsz,wght@0,14..32,100..900;1,14..32,100..900&display=swap
22-
*/
14+
// 🐨 Add the stylesheet imported from app.css!
15+
// 🐨 Add fonts and preconnect to google!
16+
// 💰 { rel: 'preconnect', href: 'https://fonts.googleapis.com' },
17+
// 💰 { rel: 'preconnect', href: 'https://fonts.gstatic.com', crossOrigin: 'anonymous' },
18+
// 💰 this is the link to the fonts we want to use:
19+
// https://fonts.googleapis.com/css2?family=Inter:ital,opsz,wght@0,14..32,100..900;1,14..32,100..900&display=swap
2320
]
2421

2522
export function Layout({ children }: { children: React.ReactNode }) {

exercises/02.metadata/02.problem.titles-react/app/root.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import tailwindStylesheet from './app.css?url'
1111
import { EpicShop } from './epicshop'
1212

1313
export const links: Route.LinksFunction = () => [
14+
{ rel: 'stylesheet', href: tailwindStylesheet },
1415
// 📜 https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/rel/preconnect
1516
{ rel: 'preconnect', href: 'https://fonts.googleapis.com' },
16-
{ rel: 'stylesheet', href: tailwindStylesheet },
1717
{
1818
rel: 'preconnect',
1919
href: 'https://fonts.gstatic.com',

0 commit comments

Comments
 (0)