Skip to content

Commit 2e07eab

Browse files
committed
refactor: comment out test job in validate.yml and add postinstall script to package.json files
1 parent b722303 commit 2e07eab

File tree

7 files changed

+28
-22
lines changed

7 files changed

+28
-22
lines changed

.github/workflows/validate.yml

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -36,28 +36,28 @@ jobs:
3636
- name: ⬣ ESLint
3737
run: npm run lint
3838

39-
tests:
40-
name: 🧪 Test
41-
timeout-minutes: 10
42-
runs-on: ubuntu-latest
43-
# Use continue-on-error to ensure this job doesn't fail the workflow
44-
continue-on-error: true
45-
46-
steps:
47-
- name: ⬇️ Checkout repo
48-
uses: actions/checkout@v4
49-
50-
- name: ⎔ Setup node
51-
uses: actions/setup-node@v4
52-
with:
53-
node-version: 24
54-
55-
- name: 📦 Install dependencies
56-
run: npm ci
57-
58-
- name: 🧪 Run tests
59-
id: run_tests
60-
run: node ./epicshop/test.js ..s
39+
# tests:
40+
# name: 🧪 Test
41+
# timeout-minutes: 10
42+
# runs-on: ubuntu-latest
43+
# # Use continue-on-error to ensure this job doesn't fail the workflow
44+
# continue-on-error: true
45+
46+
# steps:
47+
# - name: ⬇️ Checkout repo
48+
# uses: actions/checkout@v4
49+
50+
# - name: ⎔ Setup node
51+
# uses: actions/setup-node@v4
52+
# with:
53+
# node-version: 24
54+
55+
# - name: 📦 Install dependencies
56+
# run: npm ci
57+
58+
# - name: 🧪 Run tests
59+
# id: run_tests
60+
# run: node ./epicshop/test.js ..s
6161

6262
deploy:
6363
name: 🚀 Deploy

exercises/01.start/01.problem.vite-plugin/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"build": "react-router build",
1111
"dev": "react-router dev",
1212
"start": "react-router-serve build/server/index.js",
13+
"postinstall": "npm run pretypecheck",
1314
"pretypecheck": "react-router typegen",
1415
"typecheck": "tsc"
1516
},

exercises/01.start/01.solution.vite-plugin/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"build": "react-router build",
1111
"dev": "react-router dev",
1212
"start": "react-router-serve build/server/index.js",
13+
"postinstall": "npm run pretypecheck",
1314
"pretypecheck": "react-router typegen",
1415
"typecheck": "tsc"
1516
},

exercises/01.start/02.solution.loader-rsc/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"build": "react-router build",
1111
"dev": "react-router dev",
1212
"start": "react-router-serve build/server/index.js",
13+
"postinstall": "npm run pretypecheck",
1314
"pretypecheck": "react-router typegen",
1415
"typecheck": "tsc"
1516
},

exercises/01.start/03.solution.rsc-route/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"build": "react-router build",
1111
"dev": "react-router dev",
1212
"start": "react-router-serve build/server/index.js",
13+
"postinstall": "npm run pretypecheck",
1314
"pretypecheck": "react-router typegen",
1415
"typecheck": "tsc"
1516
},

exercises/01.start/04.solution.server-fns/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"build": "react-router build",
1111
"dev": "react-router dev",
1212
"start": "react-router-serve build/server/index.js",
13+
"postinstall": "npm run pretypecheck",
1314
"pretypecheck": "react-router typegen",
1415
"typecheck": "tsc"
1516
},

exercises/01.start/05.solution.use-client/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"build": "react-router build",
1111
"dev": "react-router dev",
1212
"start": "react-router-serve build/server/index.js",
13+
"postinstall": "npm run pretypecheck",
1314
"pretypecheck": "react-router typegen",
1415
"typecheck": "tsc"
1516
},

0 commit comments

Comments
 (0)