Skip to content

Commit 98ec138

Browse files
committed
refactor: simplify movie details component by removing conditional badge class
1 parent 39c565a commit 98ec138

File tree

6 files changed

+10
-34
lines changed

6 files changed

+10
-34
lines changed

exercises/01.start/01.problem.vite-plugin/app/routes/movie-details.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,8 @@ export default function MovieDetailsPage({ loaderData }: Route.ComponentProps) {
5151
</h1>
5252
<div className="mb-4 flex items-center gap-4">
5353
<span className="rr-text text-lg">{movie.year}</span>
54-
<span
55-
className={`rr-badge ${movie.isFavorite ? 'rr-badge-red' : ''}`}
56-
>
57-
Rating: {movie.rating}/10
58-
</span>
59-
<Form method="post" preventScrollReset>
54+
<span className="rr-badge">Rating: {movie.rating}/10</span>
55+
<Form method="post">
6056
<input type="hidden" name="id" value={movie.id} />
6157
<input
6258
type="hidden"

exercises/01.start/01.solution.vite-plugin/app/routes/movie-details.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,8 @@ export default function MovieDetailsPage({ loaderData }: Route.ComponentProps) {
5151
</h1>
5252
<div className="mb-4 flex items-center gap-4">
5353
<span className="rr-text text-lg">{movie.year}</span>
54-
<span
55-
className={`rr-badge ${movie.isFavorite ? 'rr-badge-red' : ''}`}
56-
>
57-
Rating: {movie.rating}/10
58-
</span>
59-
<Form method="post" preventScrollReset>
54+
<span className="rr-badge">Rating: {movie.rating}/10</span>
55+
<Form method="post">
6056
<input type="hidden" name="id" value={movie.id} />
6157
<input
6258
type="hidden"

exercises/01.start/02.solution.loader-rsc/app/routes/movie-details.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,8 @@ export default function MovieDetailsPage({ loaderData }: Route.ComponentProps) {
5151
</h1>
5252
<div className="mb-4 flex items-center gap-4">
5353
<span className="rr-text text-lg">{movie.year}</span>
54-
<span
55-
className={`rr-badge ${movie.isFavorite ? 'rr-badge-red' : ''}`}
56-
>
57-
Rating: {movie.rating}/10
58-
</span>
59-
<Form method="post" preventScrollReset>
54+
<span className="rr-badge">Rating: {movie.rating}/10</span>
55+
<Form method="post">
6056
<input type="hidden" name="id" value={movie.id} />
6157
<input
6258
type="hidden"

exercises/01.start/03.solution.rsc-route/app/routes/movie-details.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,8 @@ export default function MovieDetailsPage({ loaderData }: Route.ComponentProps) {
5151
</h1>
5252
<div className="mb-4 flex items-center gap-4">
5353
<span className="rr-text text-lg">{movie.year}</span>
54-
<span
55-
className={`rr-badge ${movie.isFavorite ? 'rr-badge-red' : ''}`}
56-
>
57-
Rating: {movie.rating}/10
58-
</span>
59-
<Form method="post" preventScrollReset>
54+
<span className="rr-badge">Rating: {movie.rating}/10</span>
55+
<Form method="post">
6056
<input type="hidden" name="id" value={movie.id} />
6157
<input
6258
type="hidden"

exercises/01.start/04.solution.server-fns/app/routes/movie-details.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,7 @@ export default function MovieDetailsPage({ loaderData }: Route.ComponentProps) {
3939
</h1>
4040
<div className="mb-4 flex items-center gap-4">
4141
<span className="rr-text text-lg">{movie.year}</span>
42-
<span
43-
className={`rr-badge ${movie.isFavorite ? 'rr-badge-red' : ''}`}
44-
>
45-
Rating: {movie.rating}/10
46-
</span>
42+
<span className="rr-badge">Rating: {movie.rating}/10</span>
4743
<form action={setIsFavorite}>
4844
<input type="hidden" name="id" value={movie.id} />
4945
<input

exercises/01.start/05.solution.use-client/app/routes/movie-details.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,7 @@ export async function ServerComponent({ params }: Route.ComponentProps) {
3434
</h1>
3535
<div className="mb-4 flex items-center gap-4">
3636
<span className="rr-text text-lg">{movie.year}</span>
37-
<span
38-
className={`rr-badge ${movie.isFavorite ? 'rr-badge-red' : ''}`}
39-
>
40-
Rating: {movie.rating}/10
41-
</span>
37+
<span className="rr-badge">Rating: {movie.rating}/10</span>
4238
<form action={setIsFavorite}>
4339
<input type="hidden" name="id" value={movie.id} />
4440
<input

0 commit comments

Comments
 (0)