add callout to include timezone #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Oct 21, 2024
kettanaito
commented
- Fixes How to best deal with timezone issues with the Date method? #26
opauloh
reviewed
Oct 22, 2024
|
|
||
| <CodeFile file="greet.test.ts" range="3-9" highlight="3,6-8" /> | ||
|
|
||
| <callout-warning>I recommend providing an entire UTC date, including an explicit timezone, as the value of the mocked date to have a resilient test setup: `new OriginalDate('2024-01-01 00:00:00.000Z')`</callout-warning> |
There was a problem hiding this comment.
That's a great addition for folks in other timezones @kettanaito!
One interesting thing although, I tested it here setting to new OriginalDate('2024-01-01 00:00:00.000Z') and it didn't work (Still getting Sunday), but when using new OriginalDate('2024-01-01 00:00:00.000') (without the Z) it worked.
I guess it's because it sets a UTC timezone, but the greet function still displays time in the Local Timezone, which means that it converts the timezone from UTC to local.
console.log(new Date('2024-01-01 00:00:00.000Z'))
// Sun Dec 31 2023 16:00:00 GMT-0800 (Pacific Standard Time)
console.log(new Date('2024-01-01 00:00:00.000'))
// Mon Jan 01 2024 00:00:00 GMT-0800 (Pacific Standard Time)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.