Skip to content

Ensure chronological ordering in join_and_score() before diff(csum) #13

@coderabbitai

Description

@coderabbitai

During the review of PR #12 (Robust fitting), CodeRabbit flagged that join_and_score() assumes rows are in ascending date order when computing diff(csum).
If the joined reference data are not sorted, negative increments can arise and CRPS will be incorrect.

Discussion thread: #12 (comment)

Action: enforce chronological ordering (e.g., sort or key by date within sample, slide) before calling diff().

Reported by @coderabbitai, requested by @jamesmbaazam.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions