You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: git-branching-merging.qmd
+3-1Lines changed: 3 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -87,14 +87,16 @@ By convention, the package maintainer is in charge of merging the pull requests.
87
87
This is indeed often more convenient as they are aware of other ongoing activities in the package that may impact or be impacted with the incoming changes.
88
88
We also have a guarantee that maintainers have sufficient permissions to merge the pull request, and potentially bypass some checks if necessary, which may not be the case of the contributor.
89
89
90
+
This recommendation remains valid even if the maintainer if the author of the pull request and they request review from a non-maintainer.
91
+
90
92
As a contributor, if you want to signal your changes are not ready to be merged, you should mark your pull requests as draft.
91
93
92
94
In all cases, communication is key.
93
95
As a maintainer, if you see a non draft pull request that looks like it might still receive additional changes, please check in with the contributor before proceeding with the merge.
94
96
Conversely, if a PR is marked as draft but seems ready to go, you can check in with the contributor if they have additional changes to make or if the PR can be marked as ready for review.
95
97
As a contributor, you can also check in with the maintainer to ensure they have not simply forgotten to merge the changes, especially if they already have approved the PR.
96
98
97
-
Note that this is only an internal convention and even though we provide reasons why this may be easier, this is not intrinsically better than other conventions.
99
+
Note that this is only an internal convention and even though we provide reasons why this may be easier, this is not intrinsically better than other conventions (e.g., PR author always merges or reviewer always merges).
98
100
The main goal is to clarify expectations to streamline process and avoid uncertainty-induced action paralysis, where everyone is waiting for the others to merge the PR.
0 commit comments