Skip to content

Commit e34c620

Browse files
committed
Clarify it is always maintainer regardless of who reviewed or opened
1 parent c5204e1 commit e34c620

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

git-branching-merging.qmd

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,16 @@ By convention, the package maintainer is in charge of merging the pull requests.
8787
This is indeed often more convenient as they are aware of other ongoing activities in the package that may impact or be impacted with the incoming changes.
8888
We also have a guarantee that maintainers have sufficient permissions to merge the pull request, and potentially bypass some checks if necessary, which may not be the case of the contributor.
8989

90+
This recommendation remains valid even if the maintainer if the author of the pull request and they request review from a non-maintainer.
91+
9092
As a contributor, if you want to signal your changes are not ready to be merged, you should mark your pull requests as draft.
9193

9294
In all cases, communication is key.
9395
As a maintainer, if you see a non draft pull request that looks like it might still receive additional changes, please check in with the contributor before proceeding with the merge.
9496
Conversely, if a PR is marked as draft but seems ready to go, you can check in with the contributor if they have additional changes to make or if the PR can be marked as ready for review.
9597
As a contributor, you can also check in with the maintainer to ensure they have not simply forgotten to merge the changes, especially if they already have approved the PR.
9698

97-
Note that this is only an internal convention and even though we provide reasons why this may be easier, this is not intrinsically better than other conventions.
99+
Note that this is only an internal convention and even though we provide reasons why this may be easier, this is not intrinsically better than other conventions (e.g., PR author always merges or reviewer always merges).
98100
The main goal is to clarify expectations to streamline process and avoid uncertainty-induced action paralysis, where everyone is waiting for the others to merge the PR.
99101

100102
## Deleting merged branches

0 commit comments

Comments
 (0)