Skip to content

Commit f434d98

Browse files
joshwlambertBisaloo
authored andcommitted
adjust wording of re-review paragraph and add point on requesting re-review
1 parent 963ef1e commit f434d98

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

code-review.qmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ One difference to highlight between the [Tidyteam principles](https://code-revie
1919

2020
Reviewers are assigned on GitHub. Those assigned should review at their earliest convenience or notify the PR author assigning them that they are unable to review. It is not mandatory for reviewers to be assigned. Reviewing a PR without being assigned can help the PR author complete the merge sooner.
2121

22-
If a PR reviewer has [_requested changes_](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#about-pull-request-reviews), it is courteous to [re-request the review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) to ensure that both the reviewer and reviewee agree the requested changes have been fully addressed, before merging. If the PR needs to be merged before a re-review can take place then this should be communicated and agreed between the PR author and reviewer.
22+
If a PR reviewer has [_requested changes_](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#about-pull-request-reviews), it is courteous to [re-request the review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) to ensure that both the reviewer and reviewee agree the requested changes have been fully addressed, before merging. If the PR needs to be merged before a re-review can take place we recommend this be communicated by the PR author to the reviewer. As a reviewer, if you would like to make sure that you have the opportunity to re-review before merging, please state this explicitly in the PR review comment.
2323

2424
It is left to the maintainer or one of the package authors of a package to merge the PR once reviewed. This ensures that code quality is maintained throughout development. The maintainer may be the PR author, in the case of requesting a code review from another member of the team, or may be the PR reviewer, when PR is opened by a contributor. PR authors cannot approve their own PRs even if they are the package maintainer.
2525

0 commit comments

Comments
 (0)