Skip to content

Commit ee39387

Browse files
authored
test: Run with Node 18, drop 12 (#829)
1 parent 252ee23 commit ee39387

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

azure-pipelines.yml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ pool:
1414
# but it let's us use a single job. No need to split up jobs yet
1515
strategy:
1616
matrix:
17-
# EOL: 2022-04-30
18-
node_12_x:
19-
node_version: 12.x
2017
# EOL: 2023-04-30
2118
node_14_x:
2219
node_version: 14.x
@@ -26,10 +23,17 @@ strategy:
2623
# EOL: 2022-06-01
2724
node_17_x:
2825
node_version: 17.x
29-
# Initial release: 2022-04-19
3026
# EOL: 2025-04-30
31-
#node_18_x:
32-
# node_version: 18.x
27+
node_18_x:
28+
node_version: 18.x
29+
# Initial release: 2022-10-18
30+
# EOL: 2023-06-01
31+
#node_19_x:
32+
# node_version: 19.x
33+
# Initial release: 2023-04-18
34+
# EOL: 2026-04-30
35+
#node_20_x:
36+
# node_version: 20.x
3337

3438
steps:
3539
- task: NodeTool@0
@@ -78,6 +82,8 @@ steps:
7882
project: $(System.TeamProject)
7983
runVersion: latestFromBranch
8084
runBranch: refs/heads/main
85+
# Needed if we introduce a new Node.js version
86+
continueOnError: true
8187

8288
- script: |
8389
mkdir $(Agent.TempDirectory)/published-previous
@@ -101,9 +107,6 @@ steps:
101107
- script: yarn start
102108
displayName: "ES modules in node smoke tests of build"
103109
workingDirectory: tests/build/fixtures/node-es-modules
104-
# in node 12 we need to use a flag and I'm too lazy to branch even further
105-
# not running in node < 13 is hopefully a sufficient smoke test
106-
condition: not(or(startsWith(variables['node_version'], '10.'), startsWith(variables['node_version'], '12.')))
107110

108111
- script: yarn test:ci
109112
displayName: "Run jest tests"

0 commit comments

Comments
 (0)