Simplify release-from-npm workflow

Author: eps1lon

.github/workflows/runtime_releases_from_npm_manual.yml

@@ -3,13 +3,9 @@ name: (Runtime) Publish Releases from NPM Manual
 on:
   workflow_dispatch:
     inputs:
-      version_to_promote:
+      prerelease:
         required: true
-        description: Current npm version (non-experimental) to promote
-        type: string
-      version_to_publish:
-        required: true
-        description: Version to publish for the specified packages
+        description: Current npm prerelease (non-experimental) to promote
         type: string
       only_packages:
         description: Packages to publish (space separated)
@@ -65,7 +61,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version-file: '.nvmrc'
+          node-version-file: ".nvmrc"
           cache: yarn
           cache-dependency-path: yarn.lock
       - name: Restore cached node_modules
@@ -82,42 +78,40 @@ jobs:
       - run: yarn --cwd scripts/release install --frozen-lockfile
         if: steps.node_modules.outputs.cache-hit != 'true'
       - run: cp ./scripts/release/ci-npmrc ~/.npmrc
-      - if: '${{ inputs.only_packages }}'
-        name: 'Prepare ${{ inputs.only_packages }} from NPM'
+      - if: "${{ inputs.only_packages }}"
+        name: "Prepare ${{ inputs.only_packages }} from NPM"
         run: |
           scripts/release/prepare-release-from-npm.js \
             --ci \
             --skipTests \
-            --version=${{ inputs.version_to_promote }} \
-            --publishVersion=${{ inputs.version_to_publish }} \
+            --prerelease=${{ inputs.prerelease }} \
             --onlyPackages=${{ inputs.only_packages }}
-      - if: '${{ inputs.skip_packages }}'
-        name: 'Prepare all packages EXCEPT ${{ inputs.skip_packages }} from NPM'
+      - if: "${{ inputs.skip_packages }}"
+        name: "Prepare all packages EXCEPT ${{ inputs.skip_packages }} from NPM"
         run: |
           scripts/release/prepare-release-from-npm.js \
             --ci \
             --skipTests \
-            --version=${{ inputs.version_to_promote }} \
-            --publishVersion=${{ inputs.version_to_publish }} \
+            --prerelease=${{ inputs.prerelease }} \
             --skipPackages=${{ inputs.skip_packages }}
       - name: Check prepared files
         run: ls -R build/node_modules
-      - if: '${{ inputs.only_packages }}'
-        name: 'Publish ${{ inputs.only_packages }}'
+      - if: "${{ inputs.only_packages }}"
+        name: "Publish ${{ inputs.only_packages }}"
         run: |
           scripts/release/publish.js \
             --ci \
             --tags=${{ inputs.tags }} \
-            --publishVersion=${{ inputs.version_to_publish }} \
+            --prerelease=${{ inputs.prerelease }} \
             --onlyPackages=${{ inputs.only_packages }} ${{ (inputs.dry && '') || '\'}}
             ${{ inputs.dry && '--dry' || '' }}
-      - if: '${{ inputs.skip_packages }}'
-        name: 'Publish all packages EXCEPT ${{ inputs.skip_packages }}'
+      - if: "${{ inputs.skip_packages }}"
+        name: "Publish all packages EXCEPT ${{ inputs.skip_packages }}"
         run: |
           scripts/release/publish.js \
             --ci \
             --tags=${{ inputs.tags }} \
-            --publishVersion=${{ inputs.version_to_publish }} \
+            --prerelease=${{ inputs.prerelease }} \
             --skipPackages=${{ inputs.skip_packages }} ${{ (inputs.dry && '') || '\'}}
             ${{ inputs.dry && '--dry' || '' }}
       - name: Archive released package for debugging

scripts/release/README.md

@@ -84,28 +84,26 @@ scripts/release/publish.js --tags experimental
 
 ## Publishing a Stable Release
 
-Stable releases should always be created from the "next" channel. This encourages better testing of the actual release artifacts and reduces the chance of unintended changes accidentally being included in a stable release.
+Stable releases should always be created from the "canary" channel. This encourages better testing of the actual release artifacts and reduces the chance of unintended changes accidentally being included in a stable release.
 
-To prepare a stable release, choose a "next" version and run the [`prepare-release-from-npm`](#prepare-release-from-npm) script <sup>1</sup>:
+To prepare a stable release, choose a "canary" version that's published on NPM.
 
-```sh
-scripts/release/prepare-release-from-npm.js --version=0.0.0-241c4467e-20200129
-```
-
-This script will prompt you to select stable version numbers for each of the packages. It will update the package JSON versions (and dependencies) based on the numbers you select.
-
-Once this step is complete, you're ready to publish the release:
+Use the prerelease part of that version as the `prerelease` parameter in https://github.com/facebook/react/actions/workflows/runtime_releases_from_npm_manual.yml.
+E.g. Use `fd524fe0-20251121` when the published Canary version is `19.3.0-canary-fd524fe0-20251121`.
 
-```sh
-scripts/release/publish.js --tags latest
-
-# Or, if you want to bump "next" as well:
-scripts/release/publish.js --tags latest next
-```
+Make sure to also include dependencies in the included packages.
+E.g. `react-dom` has a dependency on `react` and `scheduler` and  
 
-After successfully publishing the release, follow the on-screen instructions to ensure that all of the appropriate post-release steps are executed.
+### Backport
 
-<sup>1: You can omit the `version` param if you just want to promote the latest "next" candidate to stable.</sup>
+1. Pick a release commit to which you want to backport
+1. Create new branch off of that commit
+1. Push new branch to facebook/react
+1. Make sure [ReactVersions.js](./ReactVersions.js) matches the designated versions and doesn't conflict with already published stable versions
+1. Cherry-pick desired commits
+1. Push
+1. [Publish prerelease](./actions/workflows/runtime_prereleases_manual.yml) (`commit` is the newly pushed commit containing cherry-picked changes)
+1. (running the workflow on the commit that should be published) [Promote prerelease from npm](./actions/workflows/runtime_releases_from_npm_manual.yml) 
 
 ## Creating a Patch Release
 

scripts/release/prepare-release-from-npm-commands/check-out-packages.js

@@ -5,19 +5,10 @@
 const {exec} = require('child-process-promise');
 const {existsSync} = require('fs');
 const {join} = require('path');
-const {execRead, logPromise} = require('../utils');
+const {execRead} = require('../utils');
 const theme = require('../theme');
 
-const run = async ({cwd, local, packages, version}) => {
-  if (local) {
-    // Sanity test
-    if (!existsSync(join(cwd, 'build', 'node_modules', 'react'))) {
-      console.error(theme.error`No local build exists.`);
-      process.exit(1);
-    }
-    return;
-  }
-
+const run = async (packages, versionsMap, {cwd, prerelease}) => {
   if (!existsSync(join(cwd, 'build'))) {
     await exec(`mkdir ./build`, {cwd});
   }
@@ -31,6 +22,14 @@ const run = async ({cwd, local, packages, version}) => {
   // Checkout "next" release from NPM for all local packages
   for (let i = 0; i < packages.length; i++) {
     const packageName = packages[i];
+    if (!(packageName in versionsMap)) {
+      throw Error(
+        `Package "${packageName}" has no version specified. Only ${JSON.stringify(
+          Object.keys(versionsMap)
+        )} are supported are valid package names.`
+      );
+    }
+    const version = versionsMap[packageName] + '-canary-' + prerelease;
 
     // We previously used `npm install` for this,
     // but in addition to checking out a lot of transient dependencies that we don't care about–
@@ -49,12 +48,12 @@ const run = async ({cwd, local, packages, version}) => {
     await exec(`tar -xvzf ${filePath} -C ${nodeModulesPath}`, {cwd});
     await exec(`mv ${tempPackagePath} ${packagePath}`, {cwd});
     await exec(`rm ${filePath}`, {cwd});
+
+    console.log(
+      theme`{green ✔} NPM checkout {package ${packageName}}@{version ${version}}`
+    );
   }
 };
 
-module.exports = async params => {
-  return logPromise(
-    run(params),
-    theme`Checking out "next" from NPM {version ${params.version}}`
-  );
-};
+// Run this directly because logPromise would interfere with printing package dependencies.
+module.exports = run;

scripts/release/prepare-release-from-npm-commands/confirm-stable-version-numbers.js

@@ -6,13 +6,6 @@ const commandLineArgs = require('command-line-args');
 const {splitCommaParams} = require('../utils');
 
 const paramDefinitions = [
-  {
-    name: 'local',
-    type: Boolean,
-    description:
-      'Skip NPM and use the build already present in "build/node_modules".',
-    defaultValue: false,
-  },
   {
     name: 'onlyPackages',
     type: String,
@@ -34,15 +27,10 @@ const paramDefinitions = [
     defaultValue: false,
   },
   {
-    name: 'version',
+    name: 'prerelease',
     type: String,
     description:
-      'Version of published "next" release (e.g. 0.0.0-0e526bcec-20210202)',
-  },
-  {
-    name: 'publishVersion',
-    type: String,
-    description: 'Version to publish',
+      'prerelease to publish (e.g. version 19.2.0-canary-86181134-20251001 has prerelease "86181134-20251001")',
   },
   {
     name: 'ci',