Run no-implicit-ref-callback-return and react-element-default-any by default in preset-19 (#433)

Author: eps1lon

.changeset/sharp-glasses-greet.md

@@ -0,0 +1,9 @@
+---
+"types-react-codemod": minor
+---
+
+Run `no-implicit-ref-callback-return` and `react-element-default-any` by default in `preset-19`
+
+The transformed code is not meant to be used as a pattern for new code.
+It really is about migrating existing code with as little friction.
+Changes can always be reverted and a subset chosen.

README.md

@@ -83,8 +83,8 @@ The reason being that a false-positive can be reverted easily (assuming you have
   - `deprecated-react-child`
   - `deprecated-react-text`
   - `deprecated-void-function-component`
-  - `no-implicit-ref-callback-return` (off by default)
-  - `react-element-default-any` (off by default)
+  - `no-implicit-ref-callback-return`
+  - `react-element-default-any`
   - `refobject-defaults`
   - `scoped-jsx`
   - `useRef-required-initial`

bin/__tests__/types-react-codemod.js

@@ -89,7 +89,7 @@ describe("types-react-codemod", () => {
 		// Everything ok
 		expect(stderr).toMatchInlineSnapshot(`""`);
 		expect(stdout).toContain(
-			`--preset19Transforms="deprecated-legacy-ref,deprecated-prop-types-types,deprecated-react-child,deprecated-react-node-array,deprecated-react-fragment,deprecated-react-text,deprecated-void-function-component,refobject-defaults,scoped-jsx,useRef-required-initial"`,
+			`--preset19Transforms="deprecated-legacy-ref,deprecated-prop-types-types,deprecated-react-child,deprecated-react-node-array,deprecated-react-fragment,deprecated-react-text,deprecated-void-function-component,no-implicit-ref-callback-return,react-element-default-any-props,refobject-defaults,scoped-jsx,useRef-required-initial"`,
 		);
 	});
 });

bin/types-react-codemod.cjs

@@ -28,8 +28,8 @@ const preset19Choices = [
 	{ checked: true, value: "deprecated-react-fragment" },
 	{ checked: true, value: "deprecated-react-text" },
 	{ checked: true, value: "deprecated-void-function-component" },
-	{ checked: false, value: "no-implicit-ref-callback-return" },
-	{ checked: false, value: "react-element-default-any-props" },
+	{ checked: true, value: "no-implicit-ref-callback-return" },
+	{ checked: true, value: "react-element-default-any-props" },
 	{ checked: true, value: "refobject-defaults" },
 	{ checked: true, value: "scoped-jsx" },
 	{ checked: true, value: "useRef-required-initial" },