-
Notifications
You must be signed in to change notification settings - Fork 267
Open
Description
Just two things stood out:
-
The
&HashMap<u64, (u32, ConsensusFinalizedL2Block)>is -imo- non-obvious, and is passed around quite a bit. I'd document it somehow or maybe alias the numeric types in a way where its intent becomes clearer. -
The
fake_decided_blockstrick might deserve an issue. Not sure. But it looks hacky and maybe it's a case thatvalidate_block_infoshould be ready to support.
Originally posted by @t00ts in #3223 (review)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
No status