Skip to content

Commit 348306e

Browse files
author
equalsraf
committed
fixup
1 parent f5d9424 commit 348306e

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.github/workflows/build-test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,3 +129,5 @@ jobs:
129129
neovim-qt.dmg
130130
neovim-qt-installer.msi
131131
neovim-qt.zip
132+
build/test_shellwidget_output/
133+

src/gui/shellwidget/test/test_shellwidget.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,10 @@ void Test::diffWidgetOutput(QString name)
194194
QImage diff(output.size(), QImage::Format_RGB32);
195195
diff.fill(Qt::white);
196196

197-
bool failed = false;
197+
bool failed = (output.width() != expected.width()) || (output.height() != expected.height());
198+
if (failed) {
199+
qWarning() << "Output dimensions do not match";
200+
}
198201

199202
for (int y=0; y < output.height(); y++) {
200203
for (int x=0; x < output.width(); x++) {
@@ -214,9 +217,10 @@ void Test::diffWidgetOutput(QString name)
214217
qDebug() << "Saving diff" << outpath;
215218

216219

217-
if (QGuiApplication::platformName() != "xcb") {
220+
auto platform = QGuiApplication::platformName();
221+
if (platform != "xcb") {
218222
auto msg = QString("Skipping render test in non X11: %1")
219-
.arg(QGuiApplication::platformName());
223+
.arg(platform);
220224
QSKIP(qPrintable(msg));
221225
}
222226

@@ -226,7 +230,7 @@ void Test::diffWidgetOutput(QString name)
226230
QCOMPARE(output.height(), expected.height());
227231

228232
if (failed) {
229-
qWarning() << "Failing diff, check the output diff image" << outpath;
233+
qWarning() << platform << " - Failing diff, check the output diff image" << outpath;
230234
QCOMPARE(failed, false);
231235
}
232236
}

0 commit comments

Comments
 (0)