Refactor free space label in status bar update

Author: keizie

src/rpc/rpc.cpp

@@ -580,13 +580,10 @@ namespace tremotesf {
     }
 
     Coroutine<std::optional<qint64>> Rpc::getDownloadDirFreeSpace() {
-        if (isConnected()) {
-            if (mServerSettings->data().canShowFreeSpaceForPath()) {
-                co_return co_await getFreeSpaceForPathImpl(mServerSettings->data().downloadDirectory);
-            }
-            co_return co_await getDownloadDirFreeSpaceImpl();
+        if (mServerSettings->data().canShowFreeSpaceForPath()) {
+            co_return co_await getFreeSpaceForPathImpl(mServerSettings->data().downloadDirectory);
         }
-        cancelCoroutine();
+        co_return co_await getDownloadDirFreeSpaceImpl();
     }
 
     Coroutine<std::optional<qint64>> Rpc::getDownloadDirFreeSpaceImpl() {
@@ -610,13 +607,11 @@ namespace tremotesf {
     }
 
     Coroutine<std::optional<qint64>> Rpc::getFreeSpaceForPath(QString path) {
-        if (isConnected()) {
-            if (mServerSettings->data().canShowFreeSpaceForPath()) {
-                co_return co_await getFreeSpaceForPathImpl(std::move(path));
-            }
-            if (path == mServerSettings->data().downloadDirectory) {
-                co_return co_await getDownloadDirFreeSpaceImpl();
-            }
+        if (mServerSettings->data().canShowFreeSpaceForPath()) {
+            co_return co_await getFreeSpaceForPathImpl(std::move(path));
+        }
+        if (path == mServerSettings->data().downloadDirectory) {
+            co_return co_await getDownloadDirFreeSpaceImpl();
         }
         cancelCoroutine();
     }

src/ui/screens/mainwindow/mainwindowstatusbar.cpp

@@ -103,9 +103,8 @@ namespace tremotesf {
         QObject::connect(mRpc->serverStats(), &ServerStats::updated, this, [=, this] {
             mDownloadSpeedLabel->setText(formatutils::formatByteSpeed(mRpc->serverStats()->downloadSpeed()));
             mUploadSpeedLabel->setText(formatutils::formatByteSpeed(mRpc->serverStats()->uploadSpeed()));
-            mFreeSpaceLabel->setText(
-                QObject::tr("Free space: %1").arg(formatutils::formatByteSize(mRpc->serverStats()->freeSpace()))
-            );
+            mFreeSpaceLabel->setText(qApp->translate("tremotesf", "Free space: %1")
+                                         .arg(formatutils::formatByteSize(mRpc->serverStats()->freeSpace())));
         });
     }