test(consensus): added a variant of ProposalCommitted test failure

that doesn't gossip its final vote.

Author: vbar

crates/pathfinder/src/config/integration_testing.rs

@@ -26,6 +26,7 @@ pub enum InjectFailureTrigger {
     ProposalDecided,
     ProposalCommitted,
     OutdatedVote,
+    ProposalCommittedSilently,
 }
 
 impl InjectFailureTrigger {
@@ -42,6 +43,7 @@ impl InjectFailureTrigger {
             InjectFailureTrigger::ProposalDecided => "proposal_decided",
             InjectFailureTrigger::ProposalCommitted => "proposal_committed",
             InjectFailureTrigger::OutdatedVote => "outdated_vote",
+            InjectFailureTrigger::ProposalCommittedSilently => "proposal_committed_silently",
         }
     }
 }
@@ -62,6 +64,7 @@ impl FromStr for InjectFailureTrigger {
             "proposal_decided" => Ok(InjectFailureTrigger::ProposalDecided),
             "proposal_committed" => Ok(InjectFailureTrigger::ProposalCommitted),
             "outdated_vote" => Ok(InjectFailureTrigger::OutdatedVote),
+            "proposal_committed_silently" => Ok(InjectFailureTrigger::ProposalCommittedSilently),
             _ => Err(format!("Unknown inject failure event: {s}")),
         }
     }

crates/pathfinder/src/consensus/inner/integration_testing.rs

@@ -146,7 +146,13 @@ pub fn debug_fail_on_proposal_committed(
     data_directory: &Path,
 ) {
     debug_fail_on(
-        |trigger| matches!(trigger, InjectFailureTrigger::ProposalCommitted),
+        |trigger| {
+            matches!(
+                trigger,
+                InjectFailureTrigger::ProposalCommitted
+                    | InjectFailureTrigger::ProposalCommittedSilently
+            )
+        },
         height,
         inject_failure,
         data_directory,
@@ -215,3 +221,29 @@ pub fn send_outdated_vote(
 ) -> bool {
     false
 }
+
+#[cfg(all(
+    feature = "p2p",
+    feature = "consensus-integration-tests",
+    debug_assertions
+))]
+pub fn do_not_send_vote(vote_height: u64, inject_failure: Option<InjectFailureConfig>) -> bool {
+    matches!(inject_failure,
+        Some(InjectFailureConfig {
+            height,
+            trigger: InjectFailureTrigger::ProposalCommittedSilently,
+        }) if vote_height >= height
+    )
+}
+
+#[cfg(not(all(
+    feature = "p2p",
+    feature = "consensus-integration-tests",
+    debug_assertions
+)))]
+pub fn do_not_send_vote(
+    _proposal_height: u64,
+    _inject_failure: Option<InjectFailureConfig>,
+) -> bool {
+    false
+}

crates/pathfinder/src/consensus/inner/p2p_task.rs

@@ -683,7 +683,10 @@ pub fn spawn(
                         .await?;
                 }
                 ComputationSuccess::GossipVote(vote) => {
-                    gossip_handler.gossip_vote(&p2p_client, vote).await?;
+                    // The condition is always true in production builds.
+                    if !integration_testing::do_not_send_vote(vote.height, inject_failure) {
+                        gossip_handler.gossip_vote(&p2p_client, vote).await?;
+                    }
                 }
                 ComputationSuccess::PreviouslyDeferredProposalIsFinalized(hnr, commitment) => {
                     send_proposal_to_consensus(&tx_to_consensus, hnr, commitment).await;

crates/pathfinder/tests/consensus.rs

@@ -73,6 +73,7 @@ mod test {
     #[case::fail_on_prevote_rx(Some(InjectFailureConfig { height: 4, trigger: InjectFailureTrigger::PrevoteRx }))]
     #[case::fail_on_precommit_rx(Some(InjectFailureConfig { height: 4, trigger: InjectFailureTrigger::PrecommitRx }))]
     #[case::fail_on_proposal_decided(Some(InjectFailureConfig { height: 4, trigger: InjectFailureTrigger::ProposalDecided }))]
+    #[case::fail_on_proposal_committed(Some(InjectFailureConfig { height: 4, trigger: InjectFailureTrigger::ProposalCommitted }))]
     #[tokio::test]
     async fn consensus_3_nodes_with_failures(#[case] inject_failure: Option<InjectFailureConfig>) {
         const NUM_NODES: usize = 3;
@@ -233,10 +234,7 @@ mod test {
     }
 
     #[rstest]
-    // Cannot be tested with just 3 nodes b/c Bob might break the
-    // Gossip communication property when restarting - see
-    // https://github.com/eqlabs/pathfinder/issues/3286
-    #[case::fail_on_proposal_committed(InjectFailureConfig { height: 4, trigger: InjectFailureTrigger::ProposalCommitted })]
+    #[case::fail_on_proposal_committed(InjectFailureConfig { height: 4, trigger: InjectFailureTrigger::ProposalCommittedSilently })]
     #[tokio::test]
     async fn consensus_4_nodes_with_failures(#[case] inject_failure: InjectFailureConfig) {
         const NUM_NODES: usize = 4;