Add Safe Drawing Toggle To Builtin Terminal

Persist and expose a new terminal “Safe Drawing” setting from the builtin
terminal pane. The toolbar now includes a settings dropdown that lets users
toggle the feature, and the choice is saved to configuration so it survives
restart.

When the setting changes, it is applied immediately to all open terminal
views and to newly created terminals as they are opened.

* Terminal pane toolbar
* Terminal view initialization
* Configuration persistence

**Generated by CodeLite**

Signed-off-by: Eran Ifrah <eran@codelite.org>

Author: eranif

Plugin/wxTerminalCtrl/clBuiltinTerminalPane.cpp

@@ -8,6 +8,7 @@
 #include "clFileName.hpp"
 #include "clINIParser.hpp"
 #include "clWorkspaceManager.h"
+#include "cl_aui_tool_stickness.h"
 #include "codelite_events.h"
 #include "environmentconfig.h"
 #include "event_notifier.h"
@@ -23,6 +24,7 @@
 #include <wx/choicdlg.h>
 #include <wx/dir.h>
 #include <wx/frame.h>
+#include <wx/menu.h>
 #include <wx/sizer.h>
 #include <wx/xrc/xmlres.h>
 
@@ -54,6 +56,9 @@ std::map<wxString, wxString> LocateDefaultTerminals()
 clBuiltinTerminalPane::clBuiltinTerminalPane(wxWindow* parent, wxWindowID id)
     : wxPanel(parent, id)
 {
+    // Load saved settings
+    m_safeDrawingEnabled = clConfig::Get().Read("terminal/safe_drawing", false);
+
     SetSizer(new wxBoxSizer(wxVERTICAL));
     m_book = new Notebook(this,
                           wxID_ANY,
@@ -82,18 +87,22 @@ clBuiltinTerminalPane::clBuiltinTerminalPane(wxWindow* parent, wxWindowID id)
 #endif
 
     m_toolbar->AddSeparator();
-
     // Get list of terminals
     m_choice_themes = new wxChoice(m_toolbar, wxID_ANY, wxDefaultPosition, wxSize(FromDIP(200), wxNOT_FOUND));
     m_toolbar->AddControl(m_choice_themes);
     m_choice_themes->SetToolTip(_("Choose terminal theme"));
     m_choice_themes->Bind(wxEVT_CHOICE, &clBuiltinTerminalPane::OnChoiceTheme, this);
     UpdateFont();
+    m_toolbar->AddSeparator();
 
+    m_toolbar->AddTool(
+        wxID_PREFERENCES, _("Settings"), image_list->LoadBitmap("cog"), _("Terminal Settings"), wxITEM_NORMAL);
+    m_toolbar->SetToolDropDown(wxID_PREFERENCES, true);
     m_toolbar->Realize();
 
     m_toolbar->Bind(wxEVT_TOOL, &clBuiltinTerminalPane::OnNew, this, wxID_NEW);
     m_toolbar->Bind(wxEVT_TOOL, &clBuiltinTerminalPane::OnScanForTerminals, this, wxID_REFRESH);
+    m_toolbar->Bind(wxEVT_AUITOOLBAR_TOOL_DROPDOWN, &clBuiltinTerminalPane::OnSettingsMenu, this, wxID_PREFERENCES);
 
     GetSizer()->Fit(this);
     m_book->Bind(wxEVT_BOOK_PAGE_CHANGED, &clBuiltinTerminalPane::OnPageChanged, this);
@@ -147,6 +156,9 @@ void clBuiltinTerminalPane::OnNew(wxCommandEvent& event)
     TerminalView* ctrl = new TerminalView(m_book, cmd, env);
     ctrl->SetTheme(m_activeTheme.has_value() ? *m_activeTheme : wxTerminalTheme::MakeDarkTheme());
     m_book->AddPage(ctrl, cmd, true);
+
+    // Apply safe drawing setting to the new terminal
+    ctrl->EnableSafeDrawing(m_safeDrawingEnabled);
     m_book->SetPageToolTip(m_book->GetPageCount() - 1, cmd);
 
     ctrl->Bind(wxEVT_TERMINAL_TITLE_CHANGED, [ctrl, this](wxTerminalEvent& event) {
@@ -540,6 +552,43 @@ void clBuiltinTerminalPane::OnChoiceTheme(wxCommandEvent& event)
     ApplyThemeChanges();
 }
 
+void clBuiltinTerminalPane::OnSettingsMenu(wxCommandEvent& event)
+{
+    wxUnusedVar(event);
+
+    wxMenu menu;
+    wxMenuItem* safeDrawingItem = menu.AppendCheckItem(wxID_ANY, _("Enable Safe Drawing"));
+    safeDrawingItem->Check(m_safeDrawingEnabled);
+
+    menu.Bind(
+        wxEVT_MENU,
+        [this](wxCommandEvent& e) {
+            m_safeDrawingEnabled = !m_safeDrawingEnabled;
+            clDEBUG() << "Safe Drawing:" << (m_safeDrawingEnabled ? "Enabled" : "Disabled") << endl;
+
+            // Persist the setting
+            clConfig::Get().Write("terminal/safe_drawing", m_safeDrawingEnabled);
+            clConfig::Get().Save();
+
+            // Apply to all terminals
+            for (size_t i = 0; i < m_book->GetPageCount(); ++i) {
+                auto terminal = dynamic_cast<TerminalView*>(m_book->GetPage(i));
+                if (terminal) {
+                    terminal->EnableSafeDrawing(m_safeDrawingEnabled);
+                    terminal->Refresh();
+                }
+            }
+        },
+        safeDrawingItem->GetId());
+
+    wxRect rect = m_toolbar->GetToolRect(wxID_PREFERENCES);
+    wxPoint pt = m_toolbar->ClientToScreen(rect.GetBottomLeft());
+    pt = ScreenToClient(pt);
+
+    clAuiToolStickness st{m_toolbar, event.GetId()};
+    PopupMenu(&menu, pt);
+}
+
 void clBuiltinTerminalPane::ApplyThemeChanges()
 {
     if (!m_activeTheme.has_value()) {

Plugin/wxTerminalCtrl/clBuiltinTerminalPane.hpp

@@ -57,6 +57,8 @@ class WXDLLIMPEXP_SDK clBuiltinTerminalPane : public wxPanel
     void OnChoiceTheme(wxCommandEvent& event);
     void ApplyThemeChanges();
     void UpdateFont();
+    void OnSettingsMenu(wxCommandEvent& event);
+    void OnToggleSafeDrawing(wxCommandEvent& event);
 
 private:
     static std::optional<wxTerminalTheme> FromTOML(const wxFileName& filepath);
@@ -71,6 +73,7 @@ class WXDLLIMPEXP_SDK clBuiltinTerminalPane : public wxPanel
     std::map<wxString, wxTerminalTheme> m_themes;
     std::optional<wxTerminalTheme> m_activeTheme{std::nullopt};
     wxFont m_activeFont;
+    bool m_safeDrawingEnabled = false;
 };
 
 #endif // CLBUILTINTERMINALPANE_HPP

TODO.md

@@ -39,4 +39,4 @@ BUGS
 - AI: Unable to restart the client once a single "Confirm" bar was shown.
 - AI: Replace the "Confirm" dialog with a free text, allowing the user to interrupt the model.
 - AI: Extend all the tools with a "Purpose" mandatory field, so each model will be forced to report the reason for the invocation.
-
+- AI: Add a system-message that instruct the model to NEVER create a summary file