Fix crash when calling JSONItem::GetAsMap() on non-object (#3838)

Jarod42 · web-flow · commit 3e0150edfb12 · 2026-02-27T18:08:58.000+02:00
diff --git a/CodeLite/JSON.cpp b/CodeLite/JSON.cpp
@@ -182,7 +182,7 @@ JSONItem JSONItem::operator[](int index) const
 
 std::unordered_map<std::string_view, JSONItem> JSONItem::GetAsMap() const
 {
-    if (!m_json) {
+    if (!m_json || !isObject()) {
         return {};
     }
 
diff --git a/Tests/CodeliteTest/JsonTests.cpp b/Tests/CodeliteTest/JsonTests.cpp
@@ -217,9 +217,7 @@ TEST_CASE("array json")
     CHECK(!item.hasNamedObject("a"));
     CHECK(!item.namedObject("a").isOk());
     CHECK(!item["a"].isOk());
-#if 0 // crash
     CHECK(item.GetAsMap().empty());
-#endif
 }
 
 TEST_CASE("object json")

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ JSONItem JSONItem::operator[](int index) const`
`182`	`182`
`183`	`183`	`std::unordered_map<std::string_view, JSONItem> JSONItem::GetAsMap() const`
`184`	`184`	`{`
`185`		`- if (!m_json) {`
	`185`	`+ if (!m_json \|\| !isObject()) {`
`186`	`186`	`return {};`
`187`	`187`	`}`
`188`	`188`
Original file line number	Diff line number	Diff line change
`@@ -217,9 +217,7 @@ TEST_CASE("array json")`
`217`	`217`	`CHECK(!item.hasNamedObject("a"));`
`218`	`218`	`CHECK(!item.namedObject("a").isOk());`
`219`	`219`	`CHECK(!item["a"].isOk());`
`220`		`-#if 0 // crash`
`221`	`220`	`CHECK(item.GetAsMap().empty());`
`222`		`-#endif`
`223`	`221`	`}`
`224`	`222`
`225`	`223`	`TEST_CASE("object json")`