Skip to content

Commit f63451d

Browse files
authored
[rollout] fix: resource pool name in standalone mode (verl-project#4149)
### What does this PR do? fix resource pool name in standalone mode ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).)
1 parent aed2cba commit f63451d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

verl/workers/rollout/replica.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@ async def init_hybrid(self, worker_group: RayWorkerGroup):
121121
await self.launch_servers()
122122

123123
# TODO(@dyy): init with resource_pool?
124+
# TODO(sgm): this should be the default solution, but need to make the RolloutMode more clear.
124125
async def init_colocated(self, worker_group: RayWorkerGroup):
125126
"""Init colocated rollout server, rollout engine and hybrid engine colocated in same ray placement group
126127
but in separate processes.
@@ -139,7 +140,9 @@ async def init_standalone(self):
139140
# create resource pool for this rollout
140141
self.rollout_mode = RolloutMode.STANDALONE
141142
resource_pool_name = (
142-
f"rollout_pool_{self.replica_rank}" if self.is_reward_model else f"rollout_pool_reward_{self.replica_rank}"
143+
f"rollout_pool_{self.replica_rank}"
144+
if not self.is_reward_model
145+
else f"rollout_pool_reward_{self.replica_rank}"
143146
)
144147
resource_pool_spec = {
145148
resource_pool_name: [self.gpus_per_node] * self.nnodes,

0 commit comments

Comments
 (0)