revert removed global maximum duration for DefaultReporter (PR 658)

Author: mvorisek

src/Extension.php

@@ -69,6 +69,7 @@ public function __construct(array $options = [])
             $this->collector = new Collector\DefaultCollector();
             $this->reporter = new Reporter\DefaultReporter(
                 new Formatter\DefaultDurationFormatter(),
+                $maximumDuration,
                 $maximumCount
             );
         }
@@ -276,6 +277,7 @@ public function __construct(array $options = [])
             $this->collector = new Collector\DefaultCollector();
             $this->reporter = new Reporter\DefaultReporter(
                 new Formatter\DefaultDurationFormatter(),
+                $maximumDuration,
                 $maximumCount
             );
         }
@@ -429,6 +431,7 @@ public function bootstrap(
             $collector = new Collector\DefaultCollector();
             $reporter = new Reporter\DefaultReporter(
                 new Formatter\DefaultDurationFormatter(),
+                $maximumDuration,
                 $maximumCount
             );
 

src/Reporter/DefaultReporter.php

@@ -16,6 +16,7 @@
 use Ergebnis\PHPUnit\SlowTestDetector\Count;
 use Ergebnis\PHPUnit\SlowTestDetector\Formatter;
 use Ergebnis\PHPUnit\SlowTestDetector\MaximumCount;
+use Ergebnis\PHPUnit\SlowTestDetector\MaximumDuration;
 use Ergebnis\PHPUnit\SlowTestDetector\SlowTestList;
 
 /**
@@ -28,16 +29,23 @@ final class DefaultReporter implements Reporter
      */
     private $durationFormatter;
 
+    /**
+     * @var MaximumDuration
+     */
+    private $maximumDuration;
+
     /**
      * @var MaximumCount
      */
     private $maximumCount;
 
     public function __construct(
         Formatter\DurationFormatter $durationFormatter,
+        MaximumDuration $maximumDuration,
         MaximumCount $maximumCount
     ) {
         $this->durationFormatter = $durationFormatter;
+        $this->maximumDuration = $maximumDuration;
         $this->maximumCount = $maximumCount;
     }
 

test/Unit/Reporter/DefaultReporterTest.php

@@ -52,6 +52,7 @@ public function testReportReturnsEmptyStringWhenSlowTestListIsEmpty()
 
         $reporter = new Reporter\DefaultReporter(
             new Formatter\DefaultDurationFormatter(),
+            MaximumDuration::fromDuration(Duration::fromMilliseconds($faker->numberBetween(0))),
             MaximumCount::fromCount(Count::fromInt($faker->numberBetween(1)))
         );
 
@@ -65,11 +66,13 @@ public function testReportReturnsEmptyStringWhenSlowTestListIsEmpty()
      */
     public function testReportReturnsReportWhenSlowTestListHasFewerSlowTestsThanMaximumCount(
         string $expectedReport,
+        MaximumDuration $maximumDuration,
         MaximumCount $maximumCount,
         SlowTestList $slowTestList
     ) {
         $reporter = new Reporter\DefaultReporter(
             new Formatter\DefaultDurationFormatter(),
+            $maximumDuration,
             $maximumCount
         );
 
@@ -79,7 +82,7 @@ public function testReportReturnsReportWhenSlowTestListHasFewerSlowTestsThanMaxi
     }
 
     /**
-     * @return \Generator<string, array{0: string, 1: MaximumCount, 2: SlowTestList}>
+     * @return \Generator<string, array{0: string, 1: MaximumDuration, 2: MaximumCount, 3: SlowTestList}>
      */
     public static function provideExpectedReportMaximumCountAndSlowTestList(): iterable
     {
@@ -91,6 +94,7 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
 1. 00:00.300 (00:00.100) FooTest::test
 TXT
                 ,
+                MaximumDuration::fromDuration(Duration::fromMilliseconds(500)),
                 MaximumCount::fromCount(Count::fromInt(1)),
                 SlowTestList::create(
                     SlowTest::create(
@@ -109,6 +113,7 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
 2. 00:00.275 (00:00.100) BarTest::test
 TXT
                 ,
+                MaximumDuration::fromDuration(Duration::fromMilliseconds(500)),
                 MaximumCount::fromCount(Count::fromInt(2)),
                 SlowTestList::create(
                     SlowTest::create(
@@ -134,6 +139,7 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
 3. 00:00.250 (00:00.100) BazTest::test
 TXT
                 ,
+                MaximumDuration::fromDuration(Duration::fromMilliseconds(500)),
                 MaximumCount::fromCount(Count::fromInt(3)),
                 SlowTestList::create(
                     SlowTest::create(
@@ -165,6 +171,7 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
 3. 00:00.250 (00:00.100) BazTest::test
 TXT
                 ,
+                MaximumDuration::fromDuration(Duration::fromMilliseconds(500)),
                 MaximumCount::fromCount(Count::fromInt(3)),
                 SlowTestList::create(
                     SlowTest::create(
@@ -203,6 +210,7 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
 10. 00:00.110 (00:00.100) FredTest::test
 TXT
                 ,
+                MaximumDuration::fromDuration(Duration::fromMilliseconds(500)),
                 MaximumCount::fromCount(Count::fromInt(10)),
                 SlowTestList::create(
                     SlowTest::create(
@@ -276,6 +284,7 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
 There is 1 additional slow test that is not listed here.
 TXT
                 ,
+                MaximumDuration::fromDuration(Duration::fromMilliseconds(500)),
                 MaximumCount::fromCount(Count::fromInt(1)),
                 SlowTestList::create(
                     SlowTest::create(
@@ -301,6 +310,7 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
 There are 2 additional slow tests that are not listed here.
 TXT
                 ,
+                MaximumDuration::fromDuration(Duration::fromMilliseconds(500)),
                 MaximumCount::fromCount(Count::fromInt(1)),
                 SlowTestList::create(
                     SlowTest::create(
@@ -325,9 +335,10 @@ public static function provideExpectedReportMaximumCountAndSlowTestList(): itera
             ],
         ];
 
-        foreach ($values as $key => list($expected, $maximumCount, $slowTestList)) {
+        foreach ($values as $key => list($expected, $maximumDuration, $maximumCount, $slowTestList)) {
             yield $key => [
                 $expected,
+                $maximumDuration,
                 $maximumCount,
                 $slowTestList,
             ];