Skip to content
This repository was archived by the owner on Nov 19, 2020. It is now read-only.

Commit c9d9831

Browse files
authored
Merge pull request #91 from ericchiang/fix-watch-test
*: fix watch test and update tests to use v1.10.4 API server
2 parents 7f7ccea + f2e2e08 commit c9d9831

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

scripts/run-kube.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ docker run \
1414
-d \
1515
-v $TEMPDIR:/var/run/kube-test:ro \
1616
--net=host \
17-
gcr.io/google_containers/kube-apiserver-amd64:v1.7.4 \
17+
gcr.io/google_containers/kube-apiserver-amd64:v1.10.4 \
1818
kube-apiserver \
1919
--etcd-servers=http://localhost:2379 \
2020
--service-cluster-ip-range=10.0.0.1/16 \

watch_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,12 @@ func testWatch(t *testing.T, client *k8s.Client, namespace string, newCM func()
4242
if eT != eventType {
4343
t.Errorf("expected event type %q got %q", eventType, eT)
4444
}
45+
cm.GetMetadata().ResourceVersion = k8s.String("")
46+
got.GetMetadata().ResourceVersion = k8s.String("")
4547
if !reflect.DeepEqual(got, cm) {
46-
t.Errorf("configmaps did not match\nwant=%#v\ngot=%#v", cm, got)
48+
t.Errorf("configmaps didn't match")
49+
t.Errorf("want: %#v", cm)
50+
t.Errorf(" got: %#v", got)
4751
}
4852
}
4953

0 commit comments

Comments
 (0)