This PR consolidates the docker blob download functionality into the existing common_download_file_single function, eliminating code duplication and simplifying the download architecture.

Changes Made

1. Enhanced common_download_file_single function

• Added a new bool is_docker parameter (defaults to false)
• When is_docker=true, the function uses simplified download logic suitable for Docker registry blobs:
  • Skips complex caching/metadata handling (no .json files, no ETag/Last-Modified checks)
  • Performs direct file existence check for caching
  • Uses .tmp temporary files with atomic rename
  • Maintains all necessary CURL options and error handling

2. Removed common_docker_download_blob function

• Eliminated the standalone docker download function entirely
• The logic has been consolidated into common_download_file_single when is_docker=true
• Removed both CURL and non-CURL versions of the function

3. Updated docker model resolution flow

• Modified common_docker_resolve_model to use common_download_file_single(url, path, token, false, true)
• Moved docker URL resolution from common_init_from_params to common_params_handle_model
• This ensures docker URLs are resolved earlier in the parameter handling pipeline

4. Updated existing function calls

• All existing calls to common_download_file_single now explicitly pass is_docker=false
• Maintains backward compatibility for regular HTTP downloads with full caching/metadata support

Benefits

• Code consolidation: Eliminates ~70 lines of duplicate download logic
• Maintainability: Single function to maintain for all download scenarios
• Consistency: Both regular and docker downloads use the same error handling and CURL configuration
• Architecture: Better separation of concerns with docker resolution happening in parameter handling

Backward Compatibility

This change is fully backward compatible:

• Docker downloads maintain identical behavior (same CURL options, headers, error handling)
• Regular HTTP downloads are unchanged
• All existing APIs and function signatures preserved (with optional parameter addition)

The refactoring successfully addresses the original issue by removing common_docker_download_blob and using common_download_file_single with an is_docker parameter, while moving docker resolution to the appropriate location in the parameter handling flow.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.