Fix OCI progress bar trailing characters and add terminal width detection #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can pull from any OCI registry, add authentication, etc. Add docker-style progress bars and resumable downloads to OCI pulls Update documentation with progress bars and resumable downloads info Signed-off-by: Eric Curtin <[email protected]>
…d padding Co-authored-by: ericcurtin <[email protected]>
Copilot
AI
changed the title
[WIP] Fix trailing characters in OCI progress bar
Fix OCI progress bar trailing characters and add terminal width detection
Oct 19, 2025
Copilot finished work on behalf of
ericcurtin
October 19, 2025 15:36
ericcurtin
force-pushed
the
integrate-go-containerregistry-library
branch
11 times, most recently
from
e4b192d to
2935963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OCI pulling progress bar had display issues that made the output look unprofessional and difficult to read:
Trailing characters appeared when the output line shortened. For example, when download speed changed from
999.99 MB/sto13.05 MB/s, the 's' characters from the previous longer line remained visible:No terminal width adaptation: The progress bar was hardcoded to 50 characters regardless of terminal width, causing output to either overflow narrow terminals or look cramped in wide terminals.
Solution
This PR fixes both issues by:
Adding terminal width detection using
golang.org/x/termpackageDynamic progress bar sizing based on available terminal space
Proper line clearing by padding output with spaces
strings.BuilderChanges
oci-go/oci.go: RewroteprintProgress()function to implement terminal width detection and paddingoci-go/go.mod: Addedgolang.org/x/termdependencyoci-go/go.sum: Updated dependency checksumsExamples
Terminal width 60 (narrow)
Terminal width 80 (default)
Terminal width 120 (wide)
All outputs are properly padded with no trailing characters, and the progress bar adapts to the available space.
Testing
gofmtandgo vetchecksWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ggml.ai/home/REDACTED/work/llama.cpp/llama.cpp/build/bin/test-arg-parser(dns block)huggingface.co/usr/lib/git-core/git-remote-https origin REDACTED(dns block)/home/REDACTED/work/llama.cpp/llama.cpp/build/bin/test-thread-safety -hf ggml-org/models -hff tinyllamas/stories15M-q4_0.gguf -ngl 99 -p The meaning of life is -n 128 -c 256 -ub 32 -np 4 -t 2(dns block)/home/REDACTED/work/llama.cpp/llama.cpp/build/bin/llama-eval-callback --hf-repo ggml-org/models --hf-file tinyllamas/stories260K.gguf --model stories260K.gguf --prompt hello --seed 42 -ngl 0(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.