Skip to content

CURRENT_STATE.md

Latest commit

 

History

History
311 lines (244 loc) · 20.6 KB

CURRENT_STATE.md

File metadata and controls

311 lines (244 loc) · 20.6 KB

CURRENT_STATE.md

Last updated: 2026-03-21 by GitHub Copilot (epic #920 closeout) Purpose: Volatile project status for AI agent context recovery. Read this FIRST at session start.

Active Branch & PR

  • Branch: main
  • Latest SHA (main): dbe06364 (feat(scanner): cross-country analytics views (#932) (#945))
  • Open PRs: 1 (Dependabot #941 — Next.js 16.1.6→16.1.7 security patch, 5 CVEs)
  • Mode: 🟢 Clean — no active work

Recently Shipped (Epic #920 — Country-Aware Scanner & Submission Pipeline)

12/12 issues implemented, merged, and closed. Epic #920 closed.

PR Issue Summary
#933 #921 scan_country column on scan_history
#934 #922 scan_country + suggested_country on product_submissions
#935 #923 Pass user region through api_record_scan / api_submit_product
#936 #924 Frontend scan/submit country propagation
#937 #925 Admin submission review UI country context
#938 #926 Region-preferred product matching in api_record_scan
#939 #927 Cross-country product badge in scan result card
#940 #928 GS1 prefix → country hint utility function
#942 #929 Country mismatch detection badges in admin review
#943 #930 Country-scoped pending submission uniqueness
#944 #931 Country-aware submission quality scoring
#945 #932 Cross-country analytics views (3 views)

10 new migrations (20260320000100–20260321000700), 3 new views, 1 new function (gs1_country_hint), 4 modified RPC functions, 3 new QA checks (view consistency 13→16).

Recently Shipped (Session 51 — Scanner Error Recovery + Extraction)

PR Summary
#918 fix(scanner): permission-aware error recovery + extract scan page into modules (#889)

Recently Shipped (Session 49 — Next.js 16 Upgrade)

PR Summary
#904 chore(deps): bump next 15.5.12 → 16.1.6 + eslint-config-next 16.1.6 (MAJOR upgrade)

Next.js 16 compatibility fixes applied in PR #904 (6 issues discovered and resolved):

# Issue Fix
1 eslint config block removed from Next.js config API Deleted 3-line block from next.config.ts
2 eslint-config-next exports native flat config — FlatCompat wrapper caused circular JSON crash Replaced FlatCompat with direct imports in eslint.config.mjs
3 React Compiler lint rules enabled by default (4 rules, 20 violations in pre-existing code) Downgraded all 4 rules to "warn" — cleanup pass deferred
4 Route announcer __next-route-announcer__ duplicates heading text → Playwright strict mode failures Changed text= locators to getByRole("heading") in smoke.spec.ts
5 CI vitest step timeout too tight (5658 tests took 239.91s, 4m limit hit) Bumped pr-gate.yml to 6m, main-gate.yml to 7m
6 Auto-updated tsconfig.json (jsx: "react-jsx") and next-env.d.ts Accepted Next.js 16 defaults

Security CVEs patched: CVE-2025-59471, CVE-2025-59472, CVE-2026-23864

Recently Shipped (Session 50 — Scanner Black Camera Fix)

PR Summary
#916 fix(scanner): resolve black camera feed with event-driven stream readiness (#889)

6 root causes diagnosed and fixed in scan/page.tsx:

  • decodeFromVideoDevice() not awaited → now properly awaited
  • ZXing silently ignores play() rejection → 5s watchdog timeout added
  • playing event may never fire → event-driven feed detection with fallback
  • Stream readiness race condition → gated on readyState >= 2 AND videoWidth > 0
  • Missing autoPlay on video element → added for mobile browser compat
  • "Scanning…" shown without feed verification → gated on feedActive state

3 new tests + MediaStream jsdom stub. i18n: en/pl/de scan.cameraStarting key.

Recently Shipped (Session 48 — CI Baseline Restoration)

PR Summary
#914 security(frontend): prevent ReDoS in browser UA regex (SonarCloud hotspot S5852)
#907 chore(deps): bump testing group in frontend (vitest, @testing-library/react, jsdom)
#908 ci(deps): bump github-official Actions group (4 updates)
#910 ci(deps): bump treosh/lighthouse-ci-action from 12.6.1 to 12.6.2
#909 CLOSED — @vitejs/plugin-react 6.0.1 requires vite 5-6, project uses vite 7
#911 CLOSED — @eslint/js 10.0.1 requires eslint 10, project uses eslint 9

Recently Shipped (Session 47 — Post-Deploy Verification)

PR Summary
#913 fix(schema): add 5 scanner event names to analytics constraint (#889)
#906 deps(frontend): bump @supabase/supabase-js from 2.99.0 to 2.99.1 (Dependabot auto-merge)
#905 deps(frontend): bump @sentry/nextjs from 10.42.0 to 10.43.0 (Dependabot auto-merge)

Recently Shipped (Session 46 — Sprint Close-Out)

PR Summary
#912 data(scoring): populate nutri_score_source across pipeline and existing products (#893)
#903 docs(892): health-goal personalization design spec
#902 docs(ingredients): add ADR-010 ingredient language model (#890)
#901 fix(frontend): consolidate above-the-fold trust layout (#891)
#900 feat(scanner): add scanner telemetry instrumentation (#889)
#899 fix(frontend): move hardcoded English strings into i18n system (#888)
#898 fix(onboarding): remove dead health goals, fix threshold comparisons (#887)
#897 feat(frontend): add localized conflict warnings to score breakdown panel (#886)
#896 fix(scoring): add signal-conflict detection to api_score_explanation (#885)

Recently Shipped (Session 45 — Infrastructure)

PR Summary
#855 chore(state): update CURRENT_STATE.md — session 44, PR #854 merged, 207 migrations
#856 chore(state): mark PRODUCTION_URL secret as configured

CI Gate Status (main branch)

Gate Status Notes
pr-gate ✅ Typecheck, lint, unit tests, build, Playwright smoke
main-gate ✅ All passing
qa.yml ✅ 759/759 checks passing (48 suites)
deploy.yml ⚠️ 209/227 migrations on production — 18 pending deploy (epic #920)
dep-audit ✅ 0 high/critical vulnerabilities
python-lint ✅ 0 ruff errors
quality-gate ✅ Passing — ReDoS hotspot resolved (PR #914)
nightly ✅ Data audit passing
bundle-size ⚠️ Baseline shift expected after Next.js 16 MAJOR upgrade (non-blocking)

Open Issues (1 total)

Issue Priority Summary
#212 Deferred Infrastructure Cost Attribution Framework

Issue #889 fully resolved and closed with PR #918 merge. Epic #920 fully resolved and closed — all 12/12 issues shipped.

Milestones Completed

  • Milestone #17 — Elite World-Class UX v1.0: 17/17 issues shipped in PR #583 (squash merged 2026-03-03)
  • 26-PR Merge Marathon: All 26 open PRs merged in a single session (2026-03-08)

Next Planned Work

  • Playwright timeout fix + docs reconciliation (PR #829 merged)
  • Clean up 133 stale remote branches + 43 stale local branches (pruned)
  • Clean up 37 tmp-* files from repo root
  • Fix store integrity QA failures (migration 20260316000600)
  • Restore enrichment data (migration 20260313000100 BEGIN/COMMIT fix + direct piping)
  • Re-score all PL + DE categories after enrichment restoration
  • Clean up orphan ingredient_refs + deduplicate case-variant positions (migration 20260316000700)
  • Ship enrichment fix as PR (PR #833)
  • Fix 4 pre-existing QA failures — Suites 7, 10, 11, 12 (PR #834 — 47/48 pass)
  • Deploy latest changes to production — 205 migrations applied (PRs #835-#840)
  • UX Audit — 74 Playwright screenshots + 20 user screenshots analyzed → 4 issues created (#842-#845)
  • P0 fix: Score display consistency — TryVit Score (100−unhealthiness) for filters/stats (PR #846)
  • P1 fix: Category truncation, product not-found empty state, settings tab overflow (PR #847)
  • P2 fix: Language flags removed, scanner default to manual, QuickWin null guard, 403 page enhanced (PR #848)
  • P3 fix: Filter skeleton loader, category grid cleanup (PR #849)
  • Fix 7 broken production functions — STABLE→VOLATILE + watchlist alias (PR #854)
  • Configure PRODUCTION_URL secret for health endpoint verification
  • Set up staging environment — project rxtaicdpnaqigowdbmsb (eu-west-1), 207 migrations, seeded, secrets configured
  • Ship sprint issues #885–#895 (PRs #896–#903, #912)
  • Deploy migrations 20260319000400 + 20260319000500 to production (deployed 2026-03-16T08:24:26Z)
  • Verify scanner event constraint fix in production (PR #913 — all 3 layers confirmed)
  • Verify nutri_score_source backfill in production (#893 — 2,197 off_computed + 238 unknown + 3 manual)
  • Fix PR #904 — Next.js 16 MAJOR upgrade (6 compat fixes, merged as beb31a4b)
  • Review #889 observation data after 2026-03-30 checkpoint (see issue comment)

Non-Urgent Follow-Ups (from Next.js 16 upgrade)

These are documented follow-ups, not active work items. Address opportunistically or when opening next sprint.

  1. React Compiler lint warnings cleanup — 20 locations across 5 rules (set-state-in-effect ×17, preserve-manual-memoization ×1, purity ×1, refs ×1, static-components ×1). Currently downgraded to "warn" in eslint.config.mjs. Dedicated cleanup pass when convenient — no urgency.
  2. Remove @eslint/eslintrc and @eslint/js from devDependencies — These packages were used by the FlatCompat bridge which was removed in the Next 16 upgrade. They may now be unused. Verify with npx depcheck before removing.
  3. middleware.ts → proxy.ts migration — Next.js 16 deprecated the middleware.ts convention in favor of proxy.ts. Currently backward-compatible (warning only). Address when Next.js drops support or in next major framework review.

Staging Environment

  • Project: rxtaicdpnaqigowdbmsb (tryvit-staging, eu-west-1)
  • Status: ACTIVE_HEALTHY — schema deployed, reference data seeded, no product data
  • URL: https://rxtaicdpnaqigowdbmsb.supabase.co
  • Schema: 74 tables, 20 views, 4 materialized views, 257 functions, 128 RLS policies, 33 triggers
  • Reference data: 2 countries, 22 categories, 7 nutri_score, 4 concern_tiers
  • GitHub secrets: SUPABASE_STAGING_PROJECT_REF, SUPABASE_URL_STAGING, SUPABASE_ANON_KEY_STAGING, SUPABASE_SERVICE_ROLE_KEY_STAGING, STAGING_URL
  • GitHub variable: STAGING_ENABLED=true
  • CLI note: When running supabase db push against staging, set $env:SUPABASE_DB_PASSWORD to the staging password first — the --password flag does NOT override the env var.

Key Metrics Snapshot

  • Products (local DB): 2,602 active (1,380 PL + 1,222 DE across 21 active + 1 deactivated category)
  • Deprecated products: 58
  • QA checks: 759 total (48 suites) — view_consistency +3 checks for cross-country analytics views
  • Negative tests: 23/23 caught
  • EAN coverage: 2,261/2,264 with EAN (99.9%) — local DB
  • Ingredient refs: 3,100 (local, after orphan cleanup from 6,279)
  • Product-ingredient links: 14,166 (restored from 0)
  • Allergen contains: 1,395 (restored from 0)
  • Allergen traces: 1,465 (restored from 0)
  • Local ingredient coverage: PL 58.4%, DE 16.3% (OFF API data gaps)
  • Local allergen coverage: PL 44.5%, DE 13.3% (OFF API data gaps)
  • Nutrition coverage (production): 2,438/2,438 (100%)
  • Frontend test coverage: ~92% lines (SonarCloud Quality Gate passing)
  • ESLint warnings: 23 (React Compiler rules — 5 rules downgraded to warn, see follow-ups)
  • Open issues: 1 | Open PRs: 1 (Dependabot #941)
  • Vitest: 5,755 tests passing across 348 test files
  • DB migrations: 227 append-only (209 applied to production, 18 pending from epic #920)
  • pgTAP test files: 17
  • Ruff lint: 0 errors
  • GitHub Ruleset: strict_required_status_checks_policy = true

PL QA Validation Report (#595)

Date: 2026-03-05 | Branch: test/595-pl-qa-validation

Validation Results

Check Result Status
QA suites (48) 43 pass / 5 known issues ✅
Negative tests 23/23 caught ✅
EAN checksums 2,261/2,261 valid (100%) ✅
Pipeline structure 43 categories verified ✅
Enrichment identity PASSED ✅
Scoring anchor regression 9/9 verified within ±2 ✅
Data completeness avg (PL) 97.5% ✅
Min completeness (PL) 73% (Instant & Frozen) ✅

Scoring Anchor Verification

Product Expected Actual Delta Status
Piątnica Skyr Naturalny ≈5 5 0 ✅
Melvit Płatki owsiane ≈7 7 0 ✅
Tarczyński Kabanosy ≈27 27 0 ✅
Auchan Tortilla ≈29 29 0 ✅
Dr. Oetker Pizza 4 sery ≈30 30 0 ✅
Pudliszki Ketchup łagodny ≈18 33 +15 ⚠️ *
Doritos Sweet Chili ≈41 41 0 ✅
Indomie Noodles Chicken ≈43 43 0 ✅
E. Wedel Czekolada Tiramisu ≈52 52 0 ✅

* Pudliszki Ketchup: score shifted from 18→33 after enrichment (new ingredients/allergens added from OFF API). Needs anchor update in copilot-instructions.md §8.19.

Known QA Failures (Pre-existing, Non-blocking)

Suite Failures Cause
Suite 7 (DataQuality) 6 Ingredient coverage PL 58.4%/DE 16.3%, allergen coverage PL 44.5%/DE 13.3%, completeness PL 94%/DE 88.7% (all below threshold — OFF API data gaps)
Suite 10 (Naming) 2 Trailing punctuation (24 products), HTML entities (4 products)
Suite 11 (NutriRange) 4 Calorie back-calc (21), zero-cal macros (1), extreme salt (1), extreme calories (1)
Suite 12 (DataConsist) 4 nutri_score_source (fixed by PR #912), types (2), brands (886)

Root cause: Suite 7 failures are OFF API data coverage gaps (enrichment data only available for ~58% PL, ~16% DE products). Suites 10, 11, 12 are pre-existing source data quality issues unrelated to enrichment.

Session 41 fixes (migration 20260316000700 + re-scoring):

  • Suite 1 (Integrity): PASS — 3,181 orphan ingredient_ref entries removed + 18 duplicate positions deduped
  • Suite 2 (Scoring): PASS — Instant-Nudeln Beef DE anchor updated (53-57 → 43-47)
  • Suite 6 (Confidence): PASS — resolved by enrichment restoration
  • Suite 13 (Allergen): PASS — resolved by enrichment restoration
  • Suite 15 (IngredQual): PASS — resolved by orphan cleanup
  • Suite 21 (AllergenFilter): PASS — resolved by enrichment restoration
  • Suite 31 (Determinism): PASS — resolved by post-dedup re-scoring
  • Suite 32 (MultiCountry): PASS — resolved by DE re-scoring + post-dedup re-scoring

DE QA Validation Report (#602)

Date: 2026-03-05 | Branch: test/602-de-qa-validation

Validation Results

Check Result Status
Country isolation (11 checks) 11/11 pass ✅
Multi-country consistency 16/16 pass (2 bugs fixed) ✅
Scoring formula (40 checks) 39/40 pass (1 pre-exist) ✅
DE anchor regression (5 new) 5/5 pass ✅
Negative tests 23/23 caught ✅
EAN checksums 2,261/2,261 valid (100%) ✅

Bugs Fixed

Check Bug Fix
Multi-country check 1 Called stale compute_unhealthiness_v32() with old params Upgraded to v33 with _g suffix + protein/fibre
Multi-country check 10 Stale v32 + wrong column names + non-existent p.additive_count v33 + _g columns + LATERAL subquery for additives

DE Anchor Products Added (Tests 36-40)

Product Category Score Range Status
Ritter Sport Edel-Vollmilch Sweets (DE) 48 46-50 ✅
Alpro Sojadrink, Ungesüßt Drinks (DE) 8 6-10 ✅
Chipsfrisch ungarisch Chips (DE) 25 23-27 ✅
Wildlachsfilet / Golden Seafood Seafood (DE) 3 1-5 ✅
Instant-Nudeln Beef Instant (DE) 45 43-47 ✅

Maintenance Protocol

  • After every PR merge: Update "Recently Shipped" and "Active Branch" sections
  • After every session: Update "Known Issues" and "Next Planned Work"
  • Weekly: Refresh "Key Metrics Snapshot" and "CI Gate Status"